From: Rusty Russell <rusty@rustcorp.com.au>
To: Christoph Hellwig <hch@infradead.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Tomas Winkler <tomasw@gmail.com>
Subject: Re: [PATCH] CONFIG_KMOD needs to be default y
Date: Tue, 8 Jul 2008 23:03:25 +1000 [thread overview]
Message-ID: <200807082303.26194.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080708124208.GA6704@infradead.org>
On Tuesday 08 July 2008 22:42:08 Christoph Hellwig wrote:
> On Tue, Jul 08, 2008 at 01:49:31PM +0200, Johannes Berg wrote:
> > Far too many people configure their kernel without CONFIG_KMOD
> > and then complain that wireless breaks, thanks to Herbert Xu for
> > pointing me to this.
> >
> > This patch makes CONFIG_KMOD default to "y" and adds a warning
> > that people should not turn it off.
>
> What about just killing the config option entirely? It' basically
> guarding a ~50 lines function + a sysctl variable. I think having
> modules but not CONFIG_KMOD is entirely unreasonable.
I agree with Christoph here.
But as a patch series please: it's spread pretty wide. eg. first make it a
non-prompting CONFIG option, then remove the users, then finally kill it.
Some existing request_module users might be able to use
try_then_request_module, too...
Thanks!
Rusty.
next prev parent reply other threads:[~2008-07-08 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 11:49 [PATCH] CONFIG_KMOD needs to be default y Johannes Berg
2008-07-08 12:42 ` Christoph Hellwig
2008-07-08 13:03 ` Rusty Russell [this message]
2008-07-08 16:06 ` Johannes Berg
2008-07-08 16:15 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807082303.26194.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox