From: Theodore Tso <tytso@mit.edu>
To: Duane Griffin <duaneg@dghda.com>
Cc: akpm@linux-foundation.org, sct@redhat.com, adilger@clusterfs.com,
Mingming <cmm@us.ibm.com>, Sami Liedes <sliedes@cc.hut.fi>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: handle deleting corrupted indirect blocks
Date: Tue, 8 Jul 2008 22:53:04 -0400 [thread overview]
Message-ID: <20080709025304.GG9957@mit.edu> (raw)
In-Reply-To: <1215528121-26934-2-git-send-email-duaneg@dghda.com>
On Tue, Jul 08, 2008 at 03:42:00PM +0100, Duane Griffin wrote:
> + if (bh2jh(this_bh))
> + ext4_journal_dirty_metadata(handle, this_bh);
> + else
> + ext4_error(inode->i_sb, __func__,
> + "circular indirect block detected, "
> + "inode=%lu, block=%lu",
> + inode->i_ino, this_bh->b_blocknr);
this_bh->b_blocknr is a sector_t, which could be 64-bits. So this
should be:
ext4_error(inode->i_sb, __func__,
"circular indirect block detected, "
"inode=%lu, block=%llu",
inode->i_ino,
(unsigned long long) this_bh->b_blocknr);
I think.
With this change, I've included your three patches into the ext4 patch
queue.
- Ted
prev parent reply other threads:[~2008-07-09 2:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 14:41 [PATCH] ext4: handle corrupted orphan list at mount Duane Griffin
2008-07-08 14:42 ` [PATCH] ext4: handle deleting corrupted indirect blocks Duane Griffin
2008-07-08 14:42 ` [PATCH] ext4: validate directory entry data before use Duane Griffin
2008-07-09 2:53 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709025304.GG9957@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@clusterfs.com \
--cc=akpm@linux-foundation.org \
--cc=cmm@us.ibm.com \
--cc=duaneg@dghda.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=sliedes@cc.hut.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox