From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: Daniel Ribeiro <drwyrm@gmail.com>,
pHilipp Zabel <philipp.zabel@gmail.com>,
linux-arm-kernel@lists.arm.linux.org.uk, sameo@openedhand.com,
linux-kernel@vger.kernel.org
Subject: Re: [Patch 06/10] mfd: PCAP driver for the Motorola EZX GSM mobile phones
Date: Wed, 9 Jul 2008 08:26:40 +0200 [thread overview]
Message-ID: <20080709062640.GC8087@datenfreihafen.org> (raw)
In-Reply-To: <487423B3.3010604@gmail.com>
Hello.
On Wed, 2008-07-09 at 10:34, Eric Miao wrote:
>
> > o Eric, what do you like the PCAP_REDIRECT_IRQ flag to do?
> >
>
> I'm seeing the following the block of code in the original patch:
>
> +/* PCAP */
> +static int ezx_pcap_init(void)
> +{
>
> ...
>
> + /* redirect all interrupts to AP */
> + if (!(machine_is_ezx_a780() || machine_is_ezx_e680()))
> + ezx_pcap_write(PCAP_REG_INT_SEL, 0);
> +
> + return 0;
> +}
>
> that prevent this driver from being generic, a flag of PCAP_REDIRECT_IRQ
> might be used to decide the writing to PCAP_REG_INT_SEL is necessary.
Ok, now we got it. :)
Will do as requested. Array changes are pending and we also have some more
cleanups open. Will send a new patch when we have this ready.
regards
stefan Schmidt
next prev parent reply other threads:[~2008-07-09 7:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080707184000.411913919@datenfreihafen.org>
2008-07-07 18:40 ` [Patch 06/10] mfd: PCAP driver for the Motorola EZX GSM mobile phones stefan
2008-07-07 19:21 ` pHilipp Zabel
2008-07-07 20:02 ` Stefan Schmidt
2008-07-08 6:49 ` Eric Miao
2008-07-08 14:01 ` Daniel Ribeiro
2008-07-08 20:32 ` Stefan Schmidt
2008-07-08 21:19 ` pHilipp Zabel
2008-07-09 2:34 ` Eric Miao
2008-07-09 6:26 ` Stefan Schmidt [this message]
2008-07-09 15:29 ` Liam Girdwood
2008-07-10 16:21 ` Russell King - ARM Linux
2008-07-10 16:40 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080709062640.GC8087@datenfreihafen.org \
--to=stefan@datenfreihafen.org \
--cc=drwyrm@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox