public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [patch 0/17] Series to introduce WARN()... a WARN_ON() variant that takes printk arguments
Date: Wed, 9 Jul 2008 12:13:48 +0200	[thread overview]
Message-ID: <20080709101348.GA30005@elte.hu> (raw)
In-Reply-To: <20080708093800.274504ba@infradead.org>


* Arjan van de Ven <arjan@infradead.org> wrote:

> Hi,
> 
> This patch series introduces WARN(), which is a WARN_ON() variant that 
> takes printk() like arguments. This was done after both akpm and I hit 
> several cases where this would have been useful; in addition, with 
> WARN(), we put the printk string inside the -----[ cut here ]----- 
> section, making it more likely that users (and tools like kerneloops) 
> pick up the message in addition to just the bare WARNING.
> 
> The first few patches have been in -mm for a long time; the later ones 
> are newer and introduce more users of WARN().

i've created a new -git based topic branch in tip/core/warn-API and 
picked up your patches:

 Arjan van de Ven (16):
      full tree: clear the WARN() namespace
      core: add a WARN() macro that acts like WARN_ON()+printk
      kobject: introduce WARN() usage in the kobject code
      irq: use WARN() in kernel/irq/manage.c
      mm: use WARN() in mm/vmalloc.c
      lockdep: use WARN() in kernel/lockdep.c
      irq: use WARN() in kernel/irq/chip.c
      x86: use WARN() in arch/x86/mm/ioremap.c
      x86: use WARN() in arch/x86/mm/pageattr.c
      x86: use WARN() in arch/x86/kernel
      block: use WARN() in block/
      driver core: use WARN() in drivers/base/
      core libs: use WARN() in lib/
      fs: use WARN() in fs/
      sysfs: use WARN() in fs/sysfs
      procfs: use WARN() in fs/proc/

it can be picked up via:

   git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git core/warn-API

( Note, i added a few more tree-wide namespace preparation fixes to the 
  first patch - a few more came in since you first prepared this patch i 
  guess. )

	Ingo

  parent reply	other threads:[~2008-07-09 10:14 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08 16:38 [patch 0/17] Series to introduce WARN()... a WARN_ON() variant that takes printk arguments Arjan van de Ven
2008-07-08 16:39 ` [patch 1/17] Clear the WARN() namespace Arjan van de Ven
2008-07-11 19:19   ` Andrew Morton
2008-07-08 16:40 ` [patch 2/17] Add a WARN() macro that acts like WARN_ON()+printk Arjan van de Ven
2008-07-08 18:00   ` Joe Perches
2008-07-08 18:18     ` Arjan van de Ven
2008-07-11 19:19   ` Andrew Morton
2008-07-11 20:51     ` Arjan van de Ven
2008-07-08 16:41 ` [patch 3/17] Introduce WARN() usage in the kobject code Arjan van de Ven
2008-07-08 16:42 ` [patch 4/17] Use WARN() in kernel/irq/manage.c Arjan van de Ven
2008-07-08 16:45 ` [patch 5/17] Use WARN() in kernel/panic.c Arjan van de Ven
2008-07-08 16:46 ` [patch 6/17] Use WARN() in mm/vmalloc.c Arjan van de Ven
2008-07-08 16:47 ` [patch 7/17] use WARN() in kernel/lockdep.c Arjan van de Ven
2008-07-08 16:48 ` [patch 8/17] use WARN() in kernel/irq/chip.c Arjan van de Ven
2008-07-08 16:50 ` [patch 9/17] Use WARN() in arch/x86/mm/ioremap.c Arjan van de Ven
2008-07-08 16:51 ` [patch 10/17] use WARN() in arch/x86/mm/pageattr.c Arjan van de Ven
2008-07-08 16:51 ` [patch 11/17] Use WARN() in arch/x86/kernel Arjan van de Ven
2008-07-08 16:52 ` [patch 12/17] Use WARN() in block/ Arjan van de Ven
2008-07-08 16:53 ` [patch 13/17] Use WARN() in drivers/base/ Arjan van de Ven
2008-07-11 19:20   ` Andrew Morton
2008-07-11 20:54     ` Arjan van de Ven
2008-07-11 22:11       ` Andrew Morton
2008-07-11 22:35         ` Arjan van de Ven
2008-07-11 22:51         ` Arjan van de Ven
2008-07-11 23:02           ` Andrew Morton
2008-07-11 23:56             ` Arjan van de Ven
2008-07-11 23:10         ` Johannes Berg
2008-07-12  0:51           ` Johannes Berg
2008-07-08 16:53 ` [patch 14/17] Use WARN() in lib/ Arjan van de Ven
2008-07-08 16:54 ` [patch 15/17] Use WARN() in fs/ Arjan van de Ven
2008-07-08 16:54 ` Arjan van de Ven
2008-07-08 16:55 ` Arjan van de Ven
2008-07-08 16:56 ` [patch 16/17] Usr WARN() in fs/sysfs Arjan van de Ven
2008-07-08 16:57 ` [patch 17/17] Use WARN() in fs/proc/ Arjan van de Ven
2008-07-09 10:13 ` Ingo Molnar [this message]
2008-07-09 11:19   ` [patch 0/17] Series to introduce WARN()... a WARN_ON() variant that takes printk arguments Andrew Morton
2008-07-09 11:37     ` Ingo Molnar
2008-07-09 11:46       ` Andrew Morton
2008-07-09 12:13         ` Ingo Molnar
2008-07-09 13:31         ` Arjan van de Ven
  -- strict thread matches above, loose matches on Subject: below --
2008-07-08 16:38 Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080709101348.GA30005@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox