From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759414AbYGIPEx (ORCPT ); Wed, 9 Jul 2008 11:04:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758598AbYGIPDA (ORCPT ); Wed, 9 Jul 2008 11:03:00 -0400 Received: from smtp.polymtl.ca ([132.207.4.11]:41170 "EHLO smtp.polymtl.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758583AbYGIPC7 (ORCPT ); Wed, 9 Jul 2008 11:02:59 -0400 Message-Id: <20080709150047.809621885@polymtl.ca> References: <20080709145929.352201601@polymtl.ca> User-Agent: quilt/0.46-1 Date: Wed, 09 Jul 2008 10:59:42 -0400 From: Mathieu Desnoyers To: akpm@linux-foundation.org, Ingo Molnar , linux-kernel@vger.kernel.org Cc: Mathieu Desnoyers , netdev@vger.kernel.org, Jeff Garzik , Masami Hiramatsu , Peter Zijlstra , "Frank Ch. Eigler" , Hideo AOKI , Takashi Nishiie , Steven Rostedt , Eduard - Gabriel Munteanu Subject: [patch 13/15] LTTng instrumentation - net Content-Disposition: inline; filename=lttng-instrumentation-net.patch X-Poly-FromMTA: (dijkstra.casi.polymtl.ca [132.207.72.10]) at Wed, 9 Jul 2008 15:00:48 +0000 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Network device activity instrumentation (xmit/receive). Allows to detect when a packet had arrived on the network card or when it is going to be sent. This is the instrumentation point outside of the drivers that is the closest to the hardware. It allows to detect the amount of time taken by a packet to go through the kernel between the system call and the actual delivery to the network card (given that system calls are instrumented). Those tracepoints are used by LTTng. About the performance impact of tracepoints (which is comparable to markers), even without immediate values optimizations, tests done by Hideo Aoki on ia64 show no regression. His test case was using hackbench on a kernel where scheduler instrumentation (about 5 events in code scheduler code) was added. See the "Tracepoints" patch header for performance result detail. Signed-off-by: Mathieu Desnoyers CC: Andrew Morton CC: netdev@vger.kernel.org CC: Jeff Garzik CC: Masami Hiramatsu CC: 'Peter Zijlstra' CC: "Frank Ch. Eigler" CC: 'Ingo Molnar' CC: 'Hideo AOKI' CC: Takashi Nishiie CC: 'Steven Rostedt' CC: Eduard - Gabriel Munteanu --- net/core/dev.c | 4 ++++ net/core/net-trace.h | 14 ++++++++++++++ 2 files changed, 18 insertions(+) Index: linux-2.6-lttng/net/core/dev.c =================================================================== --- linux-2.6-lttng.orig/net/core/dev.c 2008-07-09 10:55:46.000000000 -0400 +++ linux-2.6-lttng/net/core/dev.c 2008-07-09 10:58:38.000000000 -0400 @@ -122,6 +122,7 @@ #include #include +#include "net-trace.h" #include "net-sysfs.h" /* @@ -1699,6 +1700,8 @@ int dev_queue_xmit(struct sk_buff *skb) } gso: + trace_net_dev_xmit(skb); + spin_lock_prefetch(&dev->queue_lock); /* Disable soft irqs for various locks below. Also @@ -2099,6 +2102,7 @@ int netif_receive_skb(struct sk_buff *sk __get_cpu_var(netdev_rx_stat).total++; + trace_net_dev_receive(skb); skb_reset_network_header(skb); skb_reset_transport_header(skb); skb->mac_len = skb->network_header - skb->mac_header; Index: linux-2.6-lttng/net/core/net-trace.h =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ linux-2.6-lttng/net/core/net-trace.h 2008-07-09 10:58:38.000000000 -0400 @@ -0,0 +1,14 @@ +#ifndef _NET_TRACE_H +#define _NET_TRACE_H + +#include +#include + +DEFINE_TRACE(net_dev_xmit, + TPPROTO(struct sk_buff *skb), + TPARGS(skb)); +DEFINE_TRACE(net_dev_receive, + TPPROTO(struct sk_buff *skb), + TPARGS(skb)); + +#endif -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68