From: Andrew Morton <akpm@linux-foundation.org>
To: Yong Wang <yong.y.wang@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Intel IOMMU: RMRRs do not necessarily have to be present on all VT-d capable platforms
Date: Thu, 10 Jul 2008 01:01:49 -0700 [thread overview]
Message-ID: <20080710010149.a73d779c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080701091354.GA12969@ywang-dev>
On Tue, 1 Jul 2008 05:13:54 -0400 Yong Wang <yong.y.wang@linux.intel.com> wrote:
> RMRRs do not necessarily have to be present on all VT-d capable platforms.
> The printk is just informational and does not need to be followed by an
> error return.
>
> Signed-off-by: Yong Y Wang <yong.y.wang@intel.com>
> ---
> dmar.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> index f941f60..8bf86ae 100644
> --- a/drivers/pci/dmar.c
> +++ b/drivers/pci/dmar.c
> @@ -317,10 +317,8 @@ int __init dmar_table_init(void)
> return -ENODEV;
> }
>
> - if (list_empty(&dmar_rmrr_units)) {
> + if (list_empty(&dmar_rmrr_units))
> printk(KERN_INFO PREFIX "No RMRR found\n");
> - return -ENODEV;
> - }
>
> return 0;
> }
>From your description I am unable to work out how important this fix is.
Is it needed in 2.6.25.x? In 2.6.26? In 2.6.27? There's no way for me to
know :(
next prev parent reply other threads:[~2008-07-10 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 9:13 [PATCH] Intel IOMMU: RMRRs do not necessarily have to be present on all VT-d capable platforms Yong Wang
2008-07-10 8:01 ` Andrew Morton [this message]
2008-07-10 23:53 ` Yong Wang
2008-07-11 0:32 ` Andrew Morton
2008-07-11 1:55 ` Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080710010149.a73d779c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yong.y.wang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox