* [PATCH] Intel IOMMU: RMRRs do not necessarily have to be present on all VT-d capable platforms
@ 2008-07-01 9:13 Yong Wang
2008-07-10 8:01 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Yong Wang @ 2008-07-01 9:13 UTC (permalink / raw)
To: linux-kernel
RMRRs do not necessarily have to be present on all VT-d capable platforms.
The printk is just informational and does not need to be followed by an
error return.
Signed-off-by: Yong Y Wang <yong.y.wang@intel.com>
---
dmar.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
index f941f60..8bf86ae 100644
--- a/drivers/pci/dmar.c
+++ b/drivers/pci/dmar.c
@@ -317,10 +317,8 @@ int __init dmar_table_init(void)
return -ENODEV;
}
- if (list_empty(&dmar_rmrr_units)) {
+ if (list_empty(&dmar_rmrr_units))
printk(KERN_INFO PREFIX "No RMRR found\n");
- return -ENODEV;
- }
return 0;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Intel IOMMU: RMRRs do not necessarily have to be present on all VT-d capable platforms
2008-07-01 9:13 [PATCH] Intel IOMMU: RMRRs do not necessarily have to be present on all VT-d capable platforms Yong Wang
@ 2008-07-10 8:01 ` Andrew Morton
2008-07-10 23:53 ` Yong Wang
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2008-07-10 8:01 UTC (permalink / raw)
To: Yong Wang; +Cc: linux-kernel
On Tue, 1 Jul 2008 05:13:54 -0400 Yong Wang <yong.y.wang@linux.intel.com> wrote:
> RMRRs do not necessarily have to be present on all VT-d capable platforms.
> The printk is just informational and does not need to be followed by an
> error return.
>
> Signed-off-by: Yong Y Wang <yong.y.wang@intel.com>
> ---
> dmar.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> index f941f60..8bf86ae 100644
> --- a/drivers/pci/dmar.c
> +++ b/drivers/pci/dmar.c
> @@ -317,10 +317,8 @@ int __init dmar_table_init(void)
> return -ENODEV;
> }
>
> - if (list_empty(&dmar_rmrr_units)) {
> + if (list_empty(&dmar_rmrr_units))
> printk(KERN_INFO PREFIX "No RMRR found\n");
> - return -ENODEV;
> - }
>
> return 0;
> }
>From your description I am unable to work out how important this fix is.
Is it needed in 2.6.25.x? In 2.6.26? In 2.6.27? There's no way for me to
know :(
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Intel IOMMU: RMRRs do not necessarily have to be present on all VT-d capable platforms
2008-07-10 8:01 ` Andrew Morton
@ 2008-07-10 23:53 ` Yong Wang
2008-07-11 0:32 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Yong Wang @ 2008-07-10 23:53 UTC (permalink / raw)
To: Andrew Morton; +Cc: Yong Wang, linux-kernel, suresh.b.siddha
On Thu, Jul 10, 2008 at 01:01:49AM -0700, Andrew Morton wrote:
> On Tue, 1 Jul 2008 05:13:54 -0400 Yong Wang <yong.y.wang@linux.intel.com> wrote:
>
> > RMRRs do not necessarily have to be present on all VT-d capable platforms.
> > The printk is just informational and does not need to be followed by an
> > error return.
> >
> > Signed-off-by: Yong Y Wang <yong.y.wang@intel.com>
> > ---
> > dmar.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> > index f941f60..8bf86ae 100644
> > --- a/drivers/pci/dmar.c
> > +++ b/drivers/pci/dmar.c
> > @@ -317,10 +317,8 @@ int __init dmar_table_init(void)
> > return -ENODEV;
> > }
> >
> > - if (list_empty(&dmar_rmrr_units)) {
> > + if (list_empty(&dmar_rmrr_units))
> > printk(KERN_INFO PREFIX "No RMRR found\n");
> > - return -ENODEV;
> > - }
> >
> > return 0;
> > }
>
> >From your description I am unable to work out how important this fix is.
>
> Is it needed in 2.6.25.x? In 2.6.26? In 2.6.27? There's no way for me to
> know :(
Actually this is the same as Suresh' x2apic patch 05/26. The absence of RMRRs
will prevent kernel from parsing IOxAPICs without this patch and thus leaves
IOxAPICs in an uninitialized state.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Intel IOMMU: RMRRs do not necessarily have to be present on all VT-d capable platforms
2008-07-10 23:53 ` Yong Wang
@ 2008-07-11 0:32 ` Andrew Morton
2008-07-11 1:55 ` Suresh Siddha
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2008-07-11 0:32 UTC (permalink / raw)
To: Yong Wang; +Cc: linux-kernel, suresh.b.siddha
On Thu, 10 Jul 2008 19:53:26 -0400 Yong Wang <yong.y.wang@linux.intel.com> wrote:
> On Thu, Jul 10, 2008 at 01:01:49AM -0700, Andrew Morton wrote:
> > On Tue, 1 Jul 2008 05:13:54 -0400 Yong Wang <yong.y.wang@linux.intel.com> wrote:
> >
> > > RMRRs do not necessarily have to be present on all VT-d capable platforms.
> > > The printk is just informational and does not need to be followed by an
> > > error return.
> > >
> > > Signed-off-by: Yong Y Wang <yong.y.wang@intel.com>
> > > ---
> > > dmar.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> > > index f941f60..8bf86ae 100644
> > > --- a/drivers/pci/dmar.c
> > > +++ b/drivers/pci/dmar.c
> > > @@ -317,10 +317,8 @@ int __init dmar_table_init(void)
> > > return -ENODEV;
> > > }
> > >
> > > - if (list_empty(&dmar_rmrr_units)) {
> > > + if (list_empty(&dmar_rmrr_units))
> > > printk(KERN_INFO PREFIX "No RMRR found\n");
> > > - return -ENODEV;
> > > - }
> > >
> > > return 0;
> > > }
> >
> > >From your description I am unable to work out how important this fix is.
> >
> > Is it needed in 2.6.25.x? In 2.6.26? In 2.6.27? There's no way for me to
> > know :(
>
> Actually this is the same as Suresh' x2apic patch 05/26. The absence of RMRRs
> will prevent kernel from parsing IOxAPICs without this patch and thus leaves
> IOxAPICs in an uninitialized state.
And what runtime effect does that have?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Intel IOMMU: RMRRs do not necessarily have to be present on all VT-d capable platforms
2008-07-11 0:32 ` Andrew Morton
@ 2008-07-11 1:55 ` Suresh Siddha
0 siblings, 0 replies; 5+ messages in thread
From: Suresh Siddha @ 2008-07-11 1:55 UTC (permalink / raw)
To: Andrew Morton; +Cc: Yong Wang, linux-kernel@vger.kernel.org, Siddha, Suresh B
On Thu, Jul 10, 2008 at 05:32:43PM -0700, Andrew Morton wrote:
> On Thu, 10 Jul 2008 19:53:26 -0400 Yong Wang <yong.y.wang@linux.intel.com> wrote:
>
> > On Thu, Jul 10, 2008 at 01:01:49AM -0700, Andrew Morton wrote:
> > > On Tue, 1 Jul 2008 05:13:54 -0400 Yong Wang <yong.y.wang@linux.intel.com> wrote:
> > >
> > > > RMRRs do not necessarily have to be present on all VT-d capable platforms.
> > > > The printk is just informational and does not need to be followed by an
> > > > error return.
> > > >
> > > > Signed-off-by: Yong Y Wang <yong.y.wang@intel.com>
> > > > ---
> > > > dmar.c | 4 +---
> > > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> > > > index f941f60..8bf86ae 100644
> > > > --- a/drivers/pci/dmar.c
> > > > +++ b/drivers/pci/dmar.c
> > > > @@ -317,10 +317,8 @@ int __init dmar_table_init(void)
> > > > return -ENODEV;
> > > > }
> > > >
> > > > - if (list_empty(&dmar_rmrr_units)) {
> > > > + if (list_empty(&dmar_rmrr_units))
> > > > printk(KERN_INFO PREFIX "No RMRR found\n");
> > > > - return -ENODEV;
> > > > - }
> > > >
> > > > return 0;
> > > > }
> > >
> > > >From your description I am unable to work out how important this fix is.
> > >
> > > Is it needed in 2.6.25.x? In 2.6.26? In 2.6.27? There's no way for me to
> > > know :(
> >
> > Actually this is the same as Suresh' x2apic patch 05/26. The absence of RMRRs
> > will prevent kernel from parsing IOxAPICs without this patch and thus leaves
> > IOxAPICs in an uninitialized state.
>
> And what runtime effect does that have?
Andrew, this is not urgent. It is now getting tracked as part of x2apic
patchset. And also, this doesn't need to be backported to any kernel.
thanks
suresh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-07-11 1:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-01 9:13 [PATCH] Intel IOMMU: RMRRs do not necessarily have to be present on all VT-d capable platforms Yong Wang
2008-07-10 8:01 ` Andrew Morton
2008-07-10 23:53 ` Yong Wang
2008-07-11 0:32 ` Andrew Morton
2008-07-11 1:55 ` Suresh Siddha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox