Re: [PATCH 0/5] x86/pci: patches for tip/x86/unify-pci

[Robert Richter <robert.richter@amd.com>]

On 10.07.08 20:12:34, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > * Robert Richter <robert.richter@amd.com> wrote:
> > 
> > > This patch series contains patches for tip/x86/unify-pci. It fixes 
> > > NUMA initialization code reflecting latest changes in tip/master. 
> > > Also there are build fixes and minor cleanups. Patch #5 is a cherry 
> > > pick that fixes build on UP systems. Code reboots for smp/nosmp, 
> > > acpi/noacpi, numaq, 32/64bit. It compiles for visws.
> > 
> > thanks Robert. Today i've eliminated the VISWS subarch which greatly 
> > simplified your series. I've picked up these two fixes:
> > 
> >  Robert Richter (2):
> >        x86/pci merge: fixing numaq initialization
> >        x86/pci: fix warnings in subsys_initcall functions
> 
> btw., this is how arch/x86/pci/Makefile looks like now in tip/master:
> 
> ----------------------------------------->
> pci-y                           := fixup.o
> pci-$(CONFIG_ACPI)              += acpi.o
> pci-y                           += legacy.o irq.o
> 
> pci-$(CONFIG_X86_VISWS)         += visws.o
> 
> pci-$(CONFIG_X86_NUMAQ)         += numa.o
> 
> obj-y                           += $(pci-y) common.o early.o
> obj-y                           += amd_bus.o
> <-----------------------------------------
> 
> it's _really_ clean now, and we dont have those weird overrides anymore. 
> Both VisWS and NUMAQ are now two straightforward runtime PCI overrides - 
> not build-time complications. Much more maintainable i think.

Yes, it really looks nice now.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com