From: Ingo Molnar <mingo@elte.hu>
To: Robert Richter <robert.richter@amd.com>
Cc: linux-kernel@vger.kernel.org,
the arch/x86 maintainers <x86@kernel.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [x86, patch] turn x86 VISWS into a generic architecture
Date: Fri, 11 Jul 2008 10:54:07 +0200 [thread overview]
Message-ID: <20080711085407.GB20987@elte.hu> (raw)
In-Reply-To: <20080711083946.GU7963@erda.amd.com>
* Robert Richter <robert.richter@amd.com> wrote:
> On 10.07.08 19:07:12, Ingo Molnar wrote:
>
> [...]
>
> > diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
> > index 99d9f09..e515e8d 100644
> > --- a/arch/x86/pci/Makefile
> > +++ b/arch/x86/pci/Makefile
> > @@ -9,9 +9,7 @@ pci-y := fixup.o
> > pci-$(CONFIG_ACPI) += acpi.o
> > pci-y += legacy.o irq.o
> >
> > -# Careful: VISWS overrule the pci-y above. The colons are
> > -# therefor correct. This needs a proper fix by distangling the code.
> > -pci-$(CONFIG_X86_VISWS) := visws.o fixup.o
> > +pci-$(CONFIG_X86_VISWS) += visws.o
>
> Ingo, if we turn this into generic code, we have to remove the
> subsys_initcall for this too. Otherwise subsystem initialization is
> running twice, in legacy.c and in visws.c.
Ok. Mind sending a patch for this against tip/master? Both your changes
and the visws cleanups are all in there and are tested through on
typical hardware.
(Also, there's the suggestion from Yinghai to first do the numa init.)
Ingo
next prev parent reply other threads:[~2008-07-11 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 17:07 [x86, patch] turn x86 VISWS into a generic architecture Ingo Molnar
2008-07-11 8:39 ` Robert Richter
2008-07-11 8:54 ` Ingo Molnar [this message]
2008-07-11 9:01 ` Yinghai Lu
2008-07-11 9:04 ` Robert Richter
2008-07-11 9:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711085407.GB20987@elte.hu \
--to=mingo@elte.hu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.richter@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox