From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Robert Richter <robert.richter@amd.com>,
linux-kernel@vger.kernel.org,
the arch/x86 maintainers <x86@kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: [x86, patch] turn x86 VISWS into a generic architecture
Date: Fri, 11 Jul 2008 11:10:41 +0200 [thread overview]
Message-ID: <20080711091041.GA30198@elte.hu> (raw)
In-Reply-To: <86802c440807110201u4ece646aw4d67a2630d653b33@mail.gmail.com>
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> > Ok. Mind sending a patch for this against tip/master? Both your
> > changes and the visws cleanups are all in there and are tested
> > through on typical hardware.
> >
> > (Also, there's the suggestion from Yinghai to first do the numa
> > init.)
>
> could change the numa.c to numaq.c too. that name is confusing..
agreed. Maybe rename it to numaq_32.c as well.
Then we could potentially eliminate the NUMAQ subarch altogether as well
and merge all it into arch/x86/kernel/numaq_quirks.c, just like we did
it for arch/x86/kernel/visws_quirks.c?
That reminds me, wouldnt it all be better in a single place, i.e. move
arch/x86/pci/visws.c into arch/x86/kernel/visws_quirks.c as well? Such
quirks are better viewed in their entirety in a single file, i'm not
sure it makes sense to spread them out.
This way, instead of having this mess of entire subarches, we'd have a
single, clean "quirks driver" file, conditionally buildable into the
generic PC code, that would register itself with all the generic quirk
hooks that are needed for a given weird box.
Ingo
prev parent reply other threads:[~2008-07-11 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 17:07 [x86, patch] turn x86 VISWS into a generic architecture Ingo Molnar
2008-07-11 8:39 ` Robert Richter
2008-07-11 8:54 ` Ingo Molnar
2008-07-11 9:01 ` Yinghai Lu
2008-07-11 9:04 ` Robert Richter
2008-07-11 9:10 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711091041.GA30198@elte.hu \
--to=mingo@elte.hu \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.richter@amd.com \
--cc=x86@kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox