* [PATCH] x86/pci: Removing pci-y in Makefile
@ 2008-07-11 10:13 Robert Richter
2008-07-11 12:04 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Robert Richter @ 2008-07-11 10:13 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner; +Cc: LKML, Robert Richter, Sam Ravnborg
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
arch/x86/pci/Makefile | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
index e515e8d..28451f4 100644
--- a/arch/x86/pci/Makefile
+++ b/arch/x86/pci/Makefile
@@ -5,13 +5,13 @@ obj-$(CONFIG_PCI_MMCONFIG) += mmconfig_$(BITS).o direct.o mmconfig-shared.o
obj-$(CONFIG_PCI_DIRECT) += direct.o
obj-$(CONFIG_PCI_OLPC) += olpc.o
-pci-y := fixup.o
-pci-$(CONFIG_ACPI) += acpi.o
-pci-y += legacy.o irq.o
+obj-y += fixup.o
+obj-$(CONFIG_ACPI) += acpi.o
+obj-y += legacy.o irq.o
-pci-$(CONFIG_X86_VISWS) += visws.o
+obj-$(CONFIG_X86_VISWS) += visws.o
-pci-$(CONFIG_X86_NUMAQ) += numa.o
+obj-$(CONFIG_X86_NUMAQ) += numa.o
-obj-y += $(pci-y) common.o early.o
+obj-y += common.o early.o
obj-y += amd_bus.o
--
1.5.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/pci: Removing pci-y in Makefile
2008-07-11 10:13 [PATCH] x86/pci: Removing pci-y in Makefile Robert Richter
@ 2008-07-11 12:04 ` Sam Ravnborg
2008-07-11 12:26 ` Robert Richter
0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2008-07-11 12:04 UTC (permalink / raw)
To: Robert Richter; +Cc: Ingo Molnar, Thomas Gleixner, LKML
On Fri, Jul 11, 2008 at 12:13:59PM +0200, Robert Richter wrote:
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Robert Richter <robert.richter@amd.com>
> ---
> arch/x86/pci/Makefile | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
> index e515e8d..28451f4 100644
> --- a/arch/x86/pci/Makefile
> +++ b/arch/x86/pci/Makefile
> @@ -5,13 +5,13 @@ obj-$(CONFIG_PCI_MMCONFIG) += mmconfig_$(BITS).o direct.o mmconfig-shared.o
> obj-$(CONFIG_PCI_DIRECT) += direct.o
> obj-$(CONFIG_PCI_OLPC) += olpc.o
>
> -pci-y := fixup.o
> -pci-$(CONFIG_ACPI) += acpi.o
> -pci-y += legacy.o irq.o
> +obj-y += fixup.o
Hi Robert.
Now I see the full patch I understood your comment.
I had missed that there was assignments above fixup.o
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/pci: Removing pci-y in Makefile
2008-07-11 12:04 ` Sam Ravnborg
@ 2008-07-11 12:26 ` Robert Richter
0 siblings, 0 replies; 3+ messages in thread
From: Robert Richter @ 2008-07-11 12:26 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Ingo Molnar, Thomas Gleixner, LKML
On 11.07.08 14:04:05, Sam Ravnborg wrote:
> On Fri, Jul 11, 2008 at 12:13:59PM +0200, Robert Richter wrote:
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Signed-off-by: Robert Richter <robert.richter@amd.com>
> > ---
> > arch/x86/pci/Makefile | 12 ++++++------
> > 1 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/x86/pci/Makefile b/arch/x86/pci/Makefile
> > index e515e8d..28451f4 100644
> > --- a/arch/x86/pci/Makefile
> > +++ b/arch/x86/pci/Makefile
> > @@ -5,13 +5,13 @@ obj-$(CONFIG_PCI_MMCONFIG) += mmconfig_$(BITS).o direct.o mmconfig-shared.o
> > obj-$(CONFIG_PCI_DIRECT) += direct.o
> > obj-$(CONFIG_PCI_OLPC) += olpc.o
> >
> > -pci-y := fixup.o
> > -pci-$(CONFIG_ACPI) += acpi.o
> > -pci-y += legacy.o irq.o
> > +obj-y += fixup.o
>
> Hi Robert.
> Now I see the full patch I understood your comment.
> I had missed that there was assignments above fixup.o
Yes, it was not the first entry.
-Robert
>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Sam
>
>
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-11 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-11 10:13 [PATCH] x86/pci: Removing pci-y in Makefile Robert Richter
2008-07-11 12:04 ` Sam Ravnborg
2008-07-11 12:26 ` Robert Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox