From: Alan Cox <alan@redhat.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "alan@redhat.com" <alan@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix ia64 simserial.c for Ldisc revamp
Date: Fri, 11 Jul 2008 09:50:31 -0400 [thread overview]
Message-ID: <20080711135031.GB23319@devserv.devel.redhat.com> (raw)
In-Reply-To: <57C9024A16AD2D4C97DC78E552063EA3064DE226@orsmsx505.amr.corp.intel.com>
On Thu, Jul 10, 2008 at 01:46:49PM -0700, Luck, Tony wrote:
> This driver is "hidden" in arch/ia64 ... so it didn't get updated
> by the Ldisc revamp.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
>
>
> @@ -354,8 +354,8 @@ static void rs_flush_buffer(struct tty_struct *tty)
> wake_up_interruptible(&tty->write_wait);
>
> if ((tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
> - tty->ldisc.write_wakeup)
> - (tty->ldisc.write_wakeup)(tty);
> + tty->ldisc.ops->write_wakeup)
> + (tty->ldisc.ops->write_wakeup)(tty);
We have a tty_wakeup method, drivers shouldn't be poking around in
tty flags any more
> - if (tty->ldisc.flush_buffer) tty->ldisc.flush_buffer(tty);
> + if (tty->ldisc.ops->flush_buffer) tty->ldisc.ops->flush_buffer(tty);
And we have a method for that too 8)
next prev parent reply other threads:[~2008-07-11 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 20:46 [PATCH] Fix ia64 simserial.c for Ldisc revamp Luck, Tony
2008-07-11 13:50 ` Alan Cox [this message]
2008-07-11 15:42 ` Alan Cox
2008-07-11 16:20 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711135031.GB23319@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox