public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] ftrace: updates
Date: Fri, 11 Jul 2008 16:47:25 +0200	[thread overview]
Message-ID: <20080711144725.GA23875@elte.hu> (raw)
In-Reply-To: <20080711135057.GC32159@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> * Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > Working on the ftrace.txt file proved to show some bugs with ftrace. 
> > These are a list of patches that I have accumulated for ftrace that 
> > solve those bugs (as well as other things).
> 
> applied them to tip/tracing/ftrace:
> 
>  Steven Rostedt (8):
>       ftrace: move sched_switch enable after markers
>       ftrace: define function trace nop
>       ftrace: trace schedule
>       ftrace: check proper config for preempt type
>       ftrace: start wakeup tracing after setting function tracer
>       ftrace: use current CPU for function startup
>       ftrace: add ftrace_kill_atomic
>       ftrace: separate out the function enabled variable

found a build bug in testing - find the fix below.

	Ingo

-------------->
commit b2613e370dbeb69edbff989382fa54f2395aa471
Author: Ingo Molnar <mingo@elte.hu>
Date:   Fri Jul 11 16:44:27 2008 +0200

    ftrace: build fix for ftraced_suspend
    
    fix:
    
     kernel/trace/ftrace.c:1615: error: 'ftraced_suspend' undeclared (first use in this function)
     kernel/trace/ftrace.c:1615: error: (Each undeclared identifier is reported only once
     kernel/trace/ftrace.c:1615: error: for each function it appears in.)
    
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/trace/ftrace.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 1359632..4231a3d 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -1612,7 +1612,9 @@ void ftrace_kill_atomic(void)
 {
 	ftrace_disabled = 1;
 	ftrace_enabled = 0;
+#ifdef CONFIG_DYNAMIC_FTRACE
 	ftraced_suspend = -1;
+#endif
 	clear_ftrace_function();
 }
 

  reply	other threads:[~2008-07-11 14:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-11  0:58 [PATCH 0/8] ftrace: updates Steven Rostedt
2008-07-11  0:58 ` [PATCH 1/8] ftrace: move sched_switch enable after markers Steven Rostedt
2008-07-11  0:58 ` [PATCH 2/8] ftrace: define function trace nop Steven Rostedt
2008-07-11  0:58 ` [PATCH 3/8] ftrace: trace schedule Steven Rostedt
2008-07-11  0:58 ` [PATCH 4/8] ftrace: check proper config for preempt type Steven Rostedt
2008-07-11  0:58 ` [PATCH 5/8] ftrace: start wakeup tracing after setting function tracer Steven Rostedt
2008-07-11  0:58 ` [PATCH 6/8] ftrace: use current CPU for function startup Steven Rostedt
2008-07-11  0:58 ` [PATCH 7/8] ftrace: add ftrace_kill_atomic Steven Rostedt
2008-07-11  0:58 ` [PATCH 8/8] ftrace: separate out the function enabled variable Steven Rostedt
2008-07-11 13:50 ` [PATCH 0/8] ftrace: updates Ingo Molnar
2008-07-11 14:47   ` Ingo Molnar [this message]
2008-07-11 14:51     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080711144725.GA23875@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox