From: Michael Buesch <mb@bu3sch.de>
To: David Brownell <david-b@pacbell.net>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
mchehab@infradead.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Marcel Holtmann <marcel@holtmann.org>
Subject: Re: [PATCH v3] Add bt8xxgpio driver
Date: Fri, 11 Jul 2008 14:53:19 +0200 [thread overview]
Message-ID: <200807111453.20162.mb@bu3sch.de> (raw)
In-Reply-To: <200807101302.12765.david-b@pacbell.net>
On Thursday 10 July 2008 22:02:12 David Brownell wrote:
> See Documentation/gpio.txt:
>
> + Note that these operations include I/O barriers on platforms
> + which need to use them; drivers don't need to add them explicitly.
>
> That's the key thing: drivers using I/O calls should
> not need to insert bus or platform specific calls to
> make sure the calls take effect.
Well, as I said, I am OK with an I/O-barrier, which is mmiowb().
But flushing, by reading the register back, is not acceptable for
me in this case, unless someone can show me hardware that needs this.
And even then I'd implement the flushing only conditionally for
that hardware.
--
Greetings Michael.
next prev parent reply other threads:[~2008-07-11 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 17:14 [PATCH v3] Add bt8xxgpio driver Michael Buesch
2008-07-10 18:15 ` Jiri Slaby
2008-07-10 18:44 ` Michael Buesch
2008-07-10 20:02 ` David Brownell
2008-07-11 12:53 ` Michael Buesch [this message]
2008-07-10 19:02 ` Mauro Carvalho Chehab
2008-07-10 19:12 ` Michael Buesch
2008-07-10 19:33 ` Mauro Carvalho Chehab
2008-07-11 13:00 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807111453.20162.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mchehab@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox