From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bridge: send correct MTU value in PMTU
Date: Fri, 11 Jul 2008 16:24:57 -0700 [thread overview]
Message-ID: <20080711162457.76afddd7@extreme> (raw)
In-Reply-To: <20080711171935.GA25603@hrz.tu-chemnitz.de>
On Fri, 11 Jul 2008 19:19:35 +0200
Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de> wrote:
> On Fri, Jul 11, 2008 at 08:34:23AM -0700, Stephen Hemminger wrote:
> > On Fri, 11 Jul 2008 14:47:35 +0200
> > Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de> wrote:
> >
> > > [...]
> >
> >
> > port should always be non-null so the existing fake_rtable can
> > just go away no?
>
> I wondered about that too. But since bridge_parent() is also checking port
> for NULL, and the code calling this is carefully checking these cases, i
> assumed that this is quite possible. If you can assert that port is
> non-NULL, we can remove this, but i have to admit that i don't get the
> whole picture to be sure about this.
bridge_parent can only be NULL if the bridge is process of deletion (via RCU).
So if bridge_parent() returns NULL, code should not bother with further processing
and return (dropping skb if this function does that).
prev parent reply other threads:[~2008-07-11 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 12:47 [PATCH] bridge: send correct MTU value in PMTU Simon Wunderlich
2008-07-11 15:34 ` Stephen Hemminger
2008-07-11 17:19 ` Simon Wunderlich
2008-07-11 23:24 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711162457.76afddd7@extreme \
--to=shemminger@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon.wunderlich@s2003.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox