From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756014AbYGKXH1 (ORCPT ); Fri, 11 Jul 2008 19:07:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752149AbYGKXHP (ORCPT ); Fri, 11 Jul 2008 19:07:15 -0400 Received: from mga14.intel.com ([143.182.124.37]:32219 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753357AbYGKXHO (ORCPT ); Fri, 11 Jul 2008 19:07:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.30,347,1212390000"; d="scan'208";a="14506540" Date: Fri, 11 Jul 2008 16:07:12 -0700 From: Suresh Siddha To: "Eric W. Biederman" Cc: "Siddha, Suresh B" , "mingo@elte.hu" , "hpa@zytor.com" , "tglx@linutronix.de" , "akpm@linux-foundation.org" , "arjan@linux.intel.com" , "andi@firstfloor.org" , "jbarnes@virtuousgeek.org" , "steiner@sgi.com" , "linux-kernel@vger.kernel.org" Subject: Re: [patch 23/26] x64, x2apic/intr-remap: MSI and MSI-X support for interrupt remapping infrastructure Message-ID: <20080711230711.GX1678@linux-os.sc.intel.com> References: <20080710181634.764954000@linux-os.sc.intel.com> <20080710182239.205057000@linux-os.sc.intel.com> <20080711060714.GT1678@linux-os.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 11, 2008 at 01:59:24AM -0700, Eric W. Biederman wrote: > What I am ultimately looking for is the x86 iommu irq mapping api. > And how we handle irqs in the context of it. > > So as a start I think we can create x86_map_irq, as I suggested. Sure. Will probably introduce irq_mapping_ops (which may be as simple as ops containing specific msi_compose_msg, ioapic_compose_rte, etc). This should simiplify the setup code. I will look into this and post these patches next week. > Since we have the pci dev to lookup the iommu then we really shouldn't Not all irq's in the platform will be remapped, for example, interrupts generated by IOMMU itself are not remapped. And all irq's don't have corresponding pci dev, like IO-APIC, MSI etc. > need multiple irq_chip structures (although it may be worth it if we > can detect we can optimize irq migration). Depending on the IOMMU/hardware, they may define different irq_chip's if they add/simplify functionality, or may use existing irq_chip's. thanks, suresh