Re: [RFC PATCH 0/5] kmemtrace RFC patch series

Mathieu Desnoyers
2008-07-11T15:39:00Z

[-- Attachment #1: Type: text/plain, Size: 2087 bytes --]

Hi Eduard,

Did you have a look at the new tracepoints infrastructure ? I think it
could simplify your patchset a _lot_ !

Basically, it removes the format string from markers and allows to pass
complex structure pointers as arguments. It aims at simplifying the life
of in-kernel tracers which would want to use the facility. Turning a
marker implementation to tracepoints is really straightforward, for an
example see :

http://lkml.org/lkml/2008/7/9/569

For the tracepoints patchset :

http://lkml.org/lkml/2008/7/9/199

I think much of include/linux/kmemtrace.h, which is really just wrappers
around marker code, could then go away.

Regards,

Mathieu

* Eduard - Gabriel Munteanu (eduard.munteanu@linux360.ro) wrote:
> Hi everybody,
>
> I'd like to hear your opinion regarding kmemtrace and SL*B hooks.
>
> This is just a RFC, it's not intended to be merged yet. The userspace
> app is not included.
>
> BTW, there may be some whitespace errors, but disregard them for now,
> they will be fixed.
>
> Cheers,
> Eduard
>
>
> Eduard - Gabriel Munteanu (5):
> kmemtrace: Core implementation.
> Add new GFP flag __GFP_NOTRACE.
> kmemtrace: SLAB hooks.
> kmemtrace: SLUB hooks.
> kmemtrace: SLOB hooks.
>
> MAINTAINERS | 6 ++
> include/linux/gfp.h | 1 +
> include/linux/kmemtrace.h | 110 +++++++++++++++++++++++
> include/linux/slab_def.h | 16 +++-
> include/linux/slub_def.h | 9 ++-
> init/main.c | 2 +
> lib/Kconfig.debug | 4 +
> mm/Makefile | 2 +-
> mm/kmemtrace.c | 213 +++++++++++++++++++++++++++++++++++++++++++++
> mm/slab.c | 35 ++++++--
> mm/slob.c | 37 +++++++--
> mm/slub.c | 49 +++++++++--
> 12 files changed, 460 insertions(+), 24 deletions(-)
> create mode 100644 include/linux/kmemtrace.h
> create mode 100644 mm/kmemtrace.c

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]