* [mmotm] relay: fix build error
@ 2008-07-12 11:14 KOSAKI Motohiro
2008-07-12 16:40 ` Eduard - Gabriel Munteanu
0 siblings, 1 reply; 2+ messages in thread
From: KOSAKI Motohiro @ 2008-07-12 11:14 UTC (permalink / raw)
To: LKML, Andrew Morton, Eduard - Gabriel Munteanu, Tom Zanussi
Cc: kosaki.motohiro
against: mmotm
patchname: relay-add-buffer-only-channels-useful-for-early-logging-fix.patch
applies after: relay-add-buffer-only-channels-useful-for-early-logging.patch
recently, smp_call_function remove retry argument.
it cause following build error on mmotm.
kernel/relay.c: In function ‘relay_late_setup_files’:
kernel/relay.c:754: error: too many arguments to function ‘smp_call_function_single’
make[1]: *** [kernel/relay.o] error 1
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Cc: Tom Zanussi <tzanussi@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
---
kernel/relay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/kernel/relay.c
===================================================================
--- a/kernel/relay.c
+++ b/kernel/relay.c
@@ -751,7 +751,7 @@ int relay_late_setup_files(struct rchan
/* relay_channels_mutex must be held, so wait. */
err = smp_call_function_single(i,
__relay_set_buf_dentry,
- &disp, 0, 1);
+ &disp, 1);
}
if (unlikely(err))
break;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [mmotm] relay: fix build error
2008-07-12 11:14 [mmotm] relay: fix build error KOSAKI Motohiro
@ 2008-07-12 16:40 ` Eduard - Gabriel Munteanu
0 siblings, 0 replies; 2+ messages in thread
From: Eduard - Gabriel Munteanu @ 2008-07-12 16:40 UTC (permalink / raw)
To: KOSAKI Motohiro; +Cc: LKML, Andrew Morton, Tom Zanussi, kosaki.motohiro
On Sat, 12 Jul 2008 20:14:21 +0900
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> against: mmotm
> patchname:
> relay-add-buffer-only-channels-useful-for-early-logging-fix.patch
> applies after:
> relay-add-buffer-only-channels-useful-for-early-logging.patch
>
> recently, smp_call_function remove retry argument.
> it cause following build error on mmotm.
>
> kernel/relay.c: In function ‘relay_late_setup_files’:
> kernel/relay.c:754: error: too many arguments to function
> ‘smp_call_function_single’ make[1]: *** [kernel/relay.o] error 1
>
>
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> CC: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
> Cc: Tom Zanussi <tzanussi@gmail.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
Thanks.
If it matters...
Acked-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
> ---
> kernel/relay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/kernel/relay.c
> ===================================================================
> --- a/kernel/relay.c
> +++ b/kernel/relay.c
> @@ -751,7 +751,7 @@ int relay_late_setup_files(struct rchan
> /* relay_channels_mutex must be held, so
> wait. */ err = smp_call_function_single(i,
> __relay_set_buf_dentry,
> - &disp, 0, 1);
> + &disp, 1);
> }
> if (unlikely(err))
> break;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-12 16:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-12 11:14 [mmotm] relay: fix build error KOSAKI Motohiro
2008-07-12 16:40 ` Eduard - Gabriel Munteanu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox