public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Olaf Dabrunz <od@suse.de>, Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Jon Masters <jonathan@jonmasters.org>,
	Stefan Assmann <sassmann@suse.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Ihno Krumreich <ihno@suse.de>, Sven Dietrich <sdietrich@suse.de>,
	Daniel Gollub <dgollub@suse.de>,
	Felix Foerster <ffoerster@suse.de>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 0/3] Boot IRQ quirks for Broadcom and AMD/ATI
Date: Sun, 13 Jul 2008 23:01:33 +0200	[thread overview]
Message-ID: <20080713210133.GA12362@elte.hu> (raw)
In-Reply-To: <12155255883170-git-send-email-od@suse.de>


* Olaf Dabrunz <od@suse.de> wrote:

> This is against linux-2.6-tip, branch pci-ioapic-boot-irq-quirks.
> 
> The corrected versions of the Broadcom and AMD/ATI boot IRQ quirks, 
> and a patch that uses DECLARE_PCI_FIXUP_FINAL instead of *_EARLY, and 
> adds *_RESUME.
> 
> The AMD/ATI SB700S does not need a quirk. The boot IRQs here are 
> active even when the IO-APIC lines are not masked. So even for 
> traditional IRQ handling that does not use masking, the boot IRQs need 
> to be disabled by the BIOS. If there are actual cases of BIOSes that 
> do not disable these boot IRQs in APIC mode, we could consider 
> including an SB700S patch. But I doubt this will be needed, as this 
> problem would quickly surface during testing with any general-purpose 
> OS.
> 
> The quirk for the AMD 8131 and AMD 8132 takes identical action as an 
> existing quirk for the AMD 8131 rev. A0 and B0. The existing quirk is 
> due to an AMD erratum to fix IO-APIC mode. Our patch now deletes the 
> older quirk and adds a comment to the new one that describes the two 
> purposes of the quirk.

applied to tip/x86/pci-ioapic-boot-irq-quirks, thanks Olaf.

Jesse, what do you think about this topic? We are keeping it separate 
for the time being. They are not particularly pretty, but being able to 
mask/unmask irqs (without generating those legacy IRQs and creating an 
IRQ storm) is essential to -rt.

	Ingo

  parent reply	other threads:[~2008-07-13 21:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08 13:59 [PATCH 0/3] Boot IRQ quirks for Broadcom and AMD/ATI Olaf Dabrunz
2008-07-08 13:59 ` [PATCH 1/3] Add quirk to disable boot interrupt generation on broadcom HT1000 Olaf Dabrunz
2008-07-08 13:59 ` [PATCH 2/3] disable AMD/ATI legacy boot interrupt generation Olaf Dabrunz
2008-07-08 13:59 ` [PATCH 3/3] call boot IRQ quirks at end of device init and during resume Olaf Dabrunz
2008-07-13 21:01 ` Ingo Molnar [this message]
2008-07-14 16:24   ` [PATCH 0/3] Boot IRQ quirks for Broadcom and AMD/ATI Jesse Barnes
2008-07-14 16:45     ` Ingo Molnar
2008-07-14 16:49       ` Olaf Dabrunz
2008-07-14 16:56         ` Jesse Barnes
2008-07-14 16:58         ` Olaf Dabrunz
2008-07-14 17:51           ` Olaf Dabrunz
2008-07-14 18:29             ` Ingo Molnar
2008-07-15  9:35               ` Olaf Dabrunz
2008-07-15 11:48             ` [PATCH] Introduce config option for pci reroute quirks (was: [PATCH 0/3] Boot IRQ quirks for Broadcom and AMD/ATI) Stefan Assmann
2008-07-18 17:31               ` Ingo Molnar
2008-07-14 17:17     ` [PATCH 0/3] Boot IRQ quirks for Broadcom and AMD/ATI Olaf Dabrunz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080713210133.GA12362@elte.hu \
    --to=mingo@elte.hu \
    --cc=dgollub@suse.de \
    --cc=ffoerster@suse.de \
    --cc=hpa@zytor.com \
    --cc=ihno@suse.de \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jonathan@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=od@suse.de \
    --cc=sassmann@suse.de \
    --cc=sdietrich@suse.de \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox