* [PATCH] x86_64: reserve crashkernel bootmem before reserve dma32 bootmem
@ 2008-07-14 17:16 Yinghai Lu
2008-07-15 0:20 ` Joe Jin
0 siblings, 1 reply; 6+ messages in thread
From: Yinghai Lu @ 2008-07-14 17:16 UTC (permalink / raw)
To: Greg KH, stable, Joe Jin
Cc: Ingo Molnar, Greg Kroah-Hartman, greg.marsden, linux-kernel,
Andi Kleen, H. Peter Anvin, Andrew Morton, Thomas Gleixner,
tao.ma
From: Joe Jin <joe.jin@oracle.com>
Before reserve_crashkernel, dma32_reserve_bootmem would reserve 128M memory.
this cuased crashkernel end address must less than 64M or start address must
more than 192M except crashkernel memory reserved before dma32 memory reserved.
Signed-off-by: Joe Jin <joe.jin@oracle.com>
Acked-by: Yinghai Lu <yhlu.kernel@gmail.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/setup_64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/arch/x86/kernel/setup_64.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/setup_64.c
+++ linux-2.6/arch/x86/kernel/setup_64.c
@@ -444,8 +444,6 @@ void __init setup_arch(char **cmdline_p)
contig_initmem_init(0, end_pfn);
#endif
- dma32_reserve_bootmem();
-
#ifdef CONFIG_ACPI_SLEEP
/*
* Reserve low memory region for sleep support.
@@ -486,6 +484,8 @@ void __init setup_arch(char **cmdline_p)
#endif
reserve_crashkernel();
+ dma32_reserve_bootmem();
+
reserve_ibft_region();
paging_init();
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86_64: reserve crashkernel bootmem before reserve dma32 bootmem
2008-07-14 17:16 [PATCH] x86_64: reserve crashkernel bootmem before reserve dma32 bootmem Yinghai Lu
@ 2008-07-15 0:20 ` Joe Jin
0 siblings, 0 replies; 6+ messages in thread
From: Joe Jin @ 2008-07-15 0:20 UTC (permalink / raw)
To: Yinghai Lu
Cc: Greg KH, stable, Joe Jin, Ingo Molnar, Greg Kroah-Hartman,
greg.marsden, linux-kernel, Andi Kleen, H. Peter Anvin,
Andrew Morton, Thomas Gleixner, tao.ma
Yinghai, thanks!
On 2008-07-14 10:16, Yinghai Lu wrote:
> From: Joe Jin <joe.jin@oracle.com>
>
> Before reserve_crashkernel, dma32_reserve_bootmem would reserve 128M memory.
> this cuased crashkernel end address must less than 64M or start address must
> more than 192M except crashkernel memory reserved before dma32 memory reserved.
>
> Signed-off-by: Joe Jin <joe.jin@oracle.com>
> Acked-by: Yinghai Lu <yhlu.kernel@gmail.com>
> Acked-by: Ingo Molnar <mingo@elte.hu>
>
>
> ---
> arch/x86/kernel/setup_64.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/arch/x86/kernel/setup_64.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/setup_64.c
> +++ linux-2.6/arch/x86/kernel/setup_64.c
> @@ -444,8 +444,6 @@ void __init setup_arch(char **cmdline_p)
> contig_initmem_init(0, end_pfn);
> #endif
>
> - dma32_reserve_bootmem();
> -
> #ifdef CONFIG_ACPI_SLEEP
> /*
> * Reserve low memory region for sleep support.
> @@ -486,6 +484,8 @@ void __init setup_arch(char **cmdline_p)
> #endif
> reserve_crashkernel();
>
> + dma32_reserve_bootmem();
> +
> reserve_ibft_region();
>
> paging_init();
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] x86_64: reserve crashkernel bootmem before reserve dma32 bootmem
@ 2008-07-10 12:34 Joe Jin
2008-07-10 17:32 ` Yinghai Lu
0 siblings, 1 reply; 6+ messages in thread
From: Joe Jin @ 2008-07-10 12:34 UTC (permalink / raw)
To: Andrew Morton, Ingo Molnar, Thomas Gleixner, H. Peter Anvin,
Yinghai Lu, Andi Kleen
Cc: greg.marsden, tao.ma, linux-kernel
Before reserve_crashkernel, dma32_reserve_bootmem would reserve 128M memory.
this cuased crashkernel end address must less than 64M or start address must
more than 192M except crashkernel memory reserved before dma32 memory reserved.
This patch against 2.6.26-rc9
Signed-off-by: Joe Jin <joe.jin@oracle.com>
---
setup_64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.26-rc9/arch/x86/kernel/setup_64.c.orig 2008-07-10 16:34:12.000000000 +0800
+++ linux-2.6.26-rc9/arch/x86/kernel/setup_64.c 2008-07-10 16:35:00.000000000 +0800
@@ -444,8 +444,6 @@ void __init setup_arch(char **cmdline_p)
contig_initmem_init(0, end_pfn);
#endif
- dma32_reserve_bootmem();
-
#ifdef CONFIG_ACPI_SLEEP
/*
* Reserve low memory region for sleep support.
@@ -486,6 +484,8 @@ void __init setup_arch(char **cmdline_p)
#endif
reserve_crashkernel();
+ dma32_reserve_bootmem();
+
reserve_ibft_region();
paging_init();
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86_64: reserve crashkernel bootmem before reserve dma32 bootmem
2008-07-10 12:34 Joe Jin
@ 2008-07-10 17:32 ` Yinghai Lu
2008-07-14 7:14 ` Yinghai Lu
0 siblings, 1 reply; 6+ messages in thread
From: Yinghai Lu @ 2008-07-10 17:32 UTC (permalink / raw)
To: Joe Jin
Cc: Andrew Morton, Ingo Molnar, Thomas Gleixner, H. Peter Anvin,
Andi Kleen, greg.marsden, tao.ma, linux-kernel
On Thu, Jul 10, 2008 at 5:34 AM, Joe Jin <joe.jin@oracle.com> wrote:
> Before reserve_crashkernel, dma32_reserve_bootmem would reserve 128M memory.
> this cuased crashkernel end address must less than 64M or start address must
> more than 192M except crashkernel memory reserved before dma32 memory reserved.
>
> This patch against 2.6.26-rc9
>
> Signed-off-by: Joe Jin <joe.jin@oracle.com>
> ---
> setup_64.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.26-rc9/arch/x86/kernel/setup_64.c.orig 2008-07-10 16:34:12.000000000 +0800
> +++ linux-2.6.26-rc9/arch/x86/kernel/setup_64.c 2008-07-10 16:35:00.000000000 +0800
> @@ -444,8 +444,6 @@ void __init setup_arch(char **cmdline_p)
> contig_initmem_init(0, end_pfn);
> #endif
>
> - dma32_reserve_bootmem();
> -
> #ifdef CONFIG_ACPI_SLEEP
> /*
> * Reserve low memory region for sleep support.
> @@ -486,6 +484,8 @@ void __init setup_arch(char **cmdline_p)
> #endif
> reserve_crashkernel();
>
> + dma32_reserve_bootmem();
> +
> reserve_ibft_region();
>
> paging_init();
Acked-by: Yinghai Lu <yhlu.kernel@gmail.com>
BTW: current tip/master already make dma32_reserve_bootmem start from 512M
http://people.redhat.com/mingo/tip.git/readme.txt
YH
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86_64: reserve crashkernel bootmem before reserve dma32 bootmem
2008-07-10 17:32 ` Yinghai Lu
@ 2008-07-14 7:14 ` Yinghai Lu
2008-07-14 7:27 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Yinghai Lu @ 2008-07-14 7:14 UTC (permalink / raw)
To: Joe Jin, Ingo Molnar
Cc: Andrew Morton, Thomas Gleixner, H. Peter Anvin, Andi Kleen,
greg.marsden, tao.ma, linux-kernel
On Thu, Jul 10, 2008 at 10:32 AM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> On Thu, Jul 10, 2008 at 5:34 AM, Joe Jin <joe.jin@oracle.com> wrote:
>> Before reserve_crashkernel, dma32_reserve_bootmem would reserve 128M memory.
>> this cuased crashkernel end address must less than 64M or start address must
>> more than 192M except crashkernel memory reserved before dma32 memory reserved.
>>
>> This patch against 2.6.26-rc9
>>
>> Signed-off-by: Joe Jin <joe.jin@oracle.com>
>> ---
>> setup_64.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --- linux-2.6.26-rc9/arch/x86/kernel/setup_64.c.orig 2008-07-10 16:34:12.000000000 +0800
>> +++ linux-2.6.26-rc9/arch/x86/kernel/setup_64.c 2008-07-10 16:35:00.000000000 +0800
>> @@ -444,8 +444,6 @@ void __init setup_arch(char **cmdline_p)
>> contig_initmem_init(0, end_pfn);
>> #endif
>>
>> - dma32_reserve_bootmem();
>> -
>> #ifdef CONFIG_ACPI_SLEEP
>> /*
>> * Reserve low memory region for sleep support.
>> @@ -486,6 +484,8 @@ void __init setup_arch(char **cmdline_p)
>> #endif
>> reserve_crashkernel();
>>
>> + dma32_reserve_bootmem();
>> +
>> reserve_ibft_region();
>>
>> paging_init();
>
> Acked-by: Yinghai Lu <yhlu.kernel@gmail.com>
>
Ingo,
it seems you missed this patch..., it should get into 2.6.26..stable..too
YH
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x86_64: reserve crashkernel bootmem before reserve dma32 bootmem
2008-07-14 7:14 ` Yinghai Lu
@ 2008-07-14 7:27 ` Ingo Molnar
0 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2008-07-14 7:27 UTC (permalink / raw)
To: Yinghai Lu
Cc: Joe Jin, Andrew Morton, Thomas Gleixner, H. Peter Anvin,
Andi Kleen, greg.marsden, tao.ma, linux-kernel, stable,
Greg Kroah-Hartman
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> On Thu, Jul 10, 2008 at 10:32 AM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> > On Thu, Jul 10, 2008 at 5:34 AM, Joe Jin <joe.jin@oracle.com> wrote:
> >> Before reserve_crashkernel, dma32_reserve_bootmem would reserve 128M memory.
> >> this cuased crashkernel end address must less than 64M or start address must
> >> more than 192M except crashkernel memory reserved before dma32 memory reserved.
> >>
> >> This patch against 2.6.26-rc9
> >>
> >> Signed-off-by: Joe Jin <joe.jin@oracle.com>
> >> ---
> >> setup_64.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> --- linux-2.6.26-rc9/arch/x86/kernel/setup_64.c.orig 2008-07-10 16:34:12.000000000 +0800
> >> +++ linux-2.6.26-rc9/arch/x86/kernel/setup_64.c 2008-07-10 16:35:00.000000000 +0800
> >> @@ -444,8 +444,6 @@ void __init setup_arch(char **cmdline_p)
> >> contig_initmem_init(0, end_pfn);
> >> #endif
> >>
> >> - dma32_reserve_bootmem();
> >> -
> >> #ifdef CONFIG_ACPI_SLEEP
> >> /*
> >> * Reserve low memory region for sleep support.
> >> @@ -486,6 +484,8 @@ void __init setup_arch(char **cmdline_p)
> >> #endif
> >> reserve_crashkernel();
> >>
> >> + dma32_reserve_bootmem();
> >> +
> >> reserve_ibft_region();
> >>
> >> paging_init();
> >
> > Acked-by: Yinghai Lu <yhlu.kernel@gmail.com>
> >
>
> Ingo,
>
> it seems you missed this patch..., it should get into
> 2.6.26..stable..too
no, i didnt miss it - but it was too late for v2.6.26 and it was in a
common x86 codepath and the code in -tip there is very different. The
fix is a proper candidate for v2.6.26.1 though - stable team Cc:-ed.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-07-15 0:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-14 17:16 [PATCH] x86_64: reserve crashkernel bootmem before reserve dma32 bootmem Yinghai Lu
2008-07-15 0:20 ` Joe Jin
-- strict thread matches above, loose matches on Subject: below --
2008-07-10 12:34 Joe Jin
2008-07-10 17:32 ` Yinghai Lu
2008-07-14 7:14 ` Yinghai Lu
2008-07-14 7:27 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox