Re: [PATCH] advansys: use request_firmware

Matthew Wilcox
2008-07-12T16:29:33Z

On Fri, Jul 11, 2008 at 03:28:42PM +0530, Jaswinder Singh wrote:
> ???this is a first draft; please be kind :)

Hi Jaswinder, I wondered when you were going to get around to advansys
;-) My concern is:

> -/* Microcode buffer is kept after initialization for error recovery. */
[...]
> + err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
> + if (err) {
> + printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
> + fwname, err);
> + return err;
> + }
> + if (fw->size < 4) {
> + printk(KERN_ERR "Bogus length %d in image \"%s\"\n",
> + fw->size, fwname);
> + release_firmware(fw);
> + return -EINVAL;
> + }
> + chksum = (fw->data[3] << 24) | (fw->data[2] << 16) |
> + (fw->data[1] << 8) | fw->data[0];
> + ASC_DBG(1, "_asc_mcode_chksum 0x%lx\n", (ulong)chksum);
> + if (AscLoadMicroCode(iop_base, 0, &fw->data[4],
> + fw->size - 4) != chksum) {
> asc_dvc->err_code |= ASC_IERR_MCODE_CHKSUM;
> return warn_code;
> }
> + release_firmware(fw);

You're calling release_firmware() here. I don't know if that actually
frees the firmware when it's built-in, but if it does, then freeing the
firmware could cause the chip to stop working if it gets reset before
userspace is up.

If it is OK to call release_firmware here, then the error path is
missing a release_firmware() call.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."