Re: [PATCH] advansys: use request_firmware

David Woodhouse
2008-07-14T14:57:13Z

On Mon, 2008-07-14 at 08:50 -0600, Matthew Wilcox wrote:
> I'm not quite sure whether my question was answered ...
>
> When firmware is built in, does
> 1) request_firmware() make a copy of it and then release_firmware free
> that copy?
> 2) request_firmware() return a pointer to the built-in firmware with
> release_firmware() being a no-op?
> 3) request_firmware() return a pointer to the built-in firmware with
> release_firmware() freeing the original?
>
> Cases 1 and 2 are fine, case 3 is a problem.

Effectively (2).

Actually we do allocate and free the 'struct firmware' but fw->data is
just pointed to the original blob, and then that blob doesn't get freed.

--
dwmw2