From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756826AbYGNOxL (ORCPT ); Mon, 14 Jul 2008 10:53:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753722AbYGNOw6 (ORCPT ); Mon, 14 Jul 2008 10:52:58 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:48670 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753583AbYGNOw5 (ORCPT ); Mon, 14 Jul 2008 10:52:57 -0400 Date: Mon, 14 Jul 2008 09:52:55 -0500 From: Jack Steiner To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] - GRU virtual -> physical translation Message-ID: <20080714145255.GA23173@sgi.com> References: <20080709191439.GA7307@sgi.com> <20080711121736.18687570.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080711121736.18687570.akpm@linux-foundation.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 11, 2008 at 12:17:36PM -0700, Andrew Morton wrote: > On Wed, 9 Jul 2008 14:14:39 -0500 Jack Steiner wrote: > > > Open code the equivalent to follow_page(). This eliminates the > > requirement for an EXPORT of follow_page(). > > I'd prefer to export follow_page() - copying-n-pasting just to avoid > exporting the darn thing is silly. If follow_page() can be EXPORTed, I think that may make the most sense for now. > > > In addition, the code > > is optimized for the specific case that is needed by the GRU and only > > supports architectures supported by the GRU (ia64 & x86_64). > > Unless you think that this alone justifies the patch? No, at least not now. We don't have enough data yet to know if the additional performance is worth having an optimized lookup routine. Currently the focus is in making the driver functionally correct. Performance optimization will be done later when we have a better understanding of the user apps that will use the GRU. _IF_ we agree to the export, what is the best way to send you the patches. Incremental or an entirely new GRU V3 patch with all issues resolved? --- jack