From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757817AbYGNUB5 (ORCPT ); Mon, 14 Jul 2008 16:01:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756378AbYGNUBt (ORCPT ); Mon, 14 Jul 2008 16:01:49 -0400 Received: from relay1.sgi.com ([192.48.171.29]:43857 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756347AbYGNUBt (ORCPT ); Mon, 14 Jul 2008 16:01:49 -0400 Date: Mon, 14 Jul 2008 15:01:45 -0500 From: Jack Steiner To: Robin Holt Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH] - GRU virtual -> physical translation Message-ID: <20080714200145.GA20064@sgi.com> References: <20080709191439.GA7307@sgi.com> <20080711121736.18687570.akpm@linux-foundation.org> <20080714145255.GA23173@sgi.com> <20080714092451.2c81a472.akpm@linux-foundation.org> <20080714163107.GA936@sgi.com> <20080714195018.GD8534@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080714195018.GD8534@sgi.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 14, 2008 at 02:50:18PM -0500, Robin Holt wrote: > On Mon, Jul 14, 2008 at 11:31:07AM -0500, Jack Steiner wrote: > > On Mon, Jul 14, 2008 at 09:24:51AM -0700, Andrew Morton wrote: > > > On Mon, 14 Jul 2008 09:52:55 -0500 Jack Steiner wrote: > > > > > > > On Fri, Jul 11, 2008 at 12:17:36PM -0700, Andrew Morton wrote: > > > > > On Wed, 9 Jul 2008 14:14:39 -0500 Jack Steiner wrote: > > > > > > > > > > > Open code the equivalent to follow_page(). This eliminates the > > > > > > requirement for an EXPORT of follow_page(). > > > > > > > > > > I'd prefer to export follow_page() - copying-n-pasting just to avoid > > > > > exporting the darn thing is silly. > > > > > > > > If follow_page() can be EXPORTed, I think that may make the most sense for > > > > now. > > > > > > What was Christoph's reason for objecting to the export? > > > > No clue. Just a NACK. > > > > Christoph??? > > Maybe I missed part of the discussion, but I thought follow_page() would > not work because you need this to function in the interrupt context and > locks would then need to be made irqsave/irqrestore. Arggg. You are right. I forgot the issue with the pte locks. Looks like I am back to the plan suggested by Nick. I'll add a get_user_pte_fast() function to gup.c. The pte lookup function is very similar to the get_user_pages_fast() function. Ignore the previous noise about follow_page(). --- jack