Re: [PATCH] Fix pci_subsys_init() to have a return value

[Robert Richter <robert.richter@amd.com>]

On 14.07.08 14:21:03, Jesse Barnes wrote:
> On Friday, July 11, 2008 2:46 am David Howells wrote:
> > Fix pci_subsys_init() to return a value (0) when it has finished.  All the
> > functions it calls currently return 0, so returning 0 here unconditionally
> > rather than gathering the results of its callees would seem reasonable.
> >
> > Signed-off-by: David Howells <dhowells@redhat.com>
> > ---
> >
> >  arch/x86/pci/legacy.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >
> > diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
> > index 3c1d795..00e29c8 100644
> > --- a/arch/x86/pci/legacy.c
> > +++ b/arch/x86/pci/legacy.c
> > @@ -63,5 +63,6 @@ int __init pci_subsys_init(void)
> >  	pci_legacy_init();
> >  	pcibios_irq_init();
> >  	pcibios_init();
> > +	return 0;
> >  }
> >  subsys_initcall(pci_subsys_init);
> 
> Looks like Robert already pushed a patch like this via the x86 tree, but at 
> least it's been fixed.

Right, there was also another location to fix.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com