* [PATCH] Fix pci_subsys_init() to have a return value
@ 2008-07-11 9:46 David Howells
2008-07-14 21:21 ` Jesse Barnes
0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2008-07-11 9:46 UTC (permalink / raw)
To: jbarnes, akpm; +Cc: dhowells, linux-pci, linux-kernel
Fix pci_subsys_init() to return a value (0) when it has finished. All the
functions it calls currently return 0, so returning 0 here unconditionally
rather than gathering the results of its callees would seem reasonable.
Signed-off-by: David Howells <dhowells@redhat.com>
---
arch/x86/pci/legacy.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
index 3c1d795..00e29c8 100644
--- a/arch/x86/pci/legacy.c
+++ b/arch/x86/pci/legacy.c
@@ -63,5 +63,6 @@ int __init pci_subsys_init(void)
pci_legacy_init();
pcibios_irq_init();
pcibios_init();
+ return 0;
}
subsys_initcall(pci_subsys_init);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix pci_subsys_init() to have a return value
2008-07-11 9:46 [PATCH] Fix pci_subsys_init() to have a return value David Howells
@ 2008-07-14 21:21 ` Jesse Barnes
2008-07-14 22:25 ` Robert Richter
0 siblings, 1 reply; 3+ messages in thread
From: Jesse Barnes @ 2008-07-14 21:21 UTC (permalink / raw)
To: David Howells; +Cc: akpm, linux-pci, linux-kernel
On Friday, July 11, 2008 2:46 am David Howells wrote:
> Fix pci_subsys_init() to return a value (0) when it has finished. All the
> functions it calls currently return 0, so returning 0 here unconditionally
> rather than gathering the results of its callees would seem reasonable.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> arch/x86/pci/legacy.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
> index 3c1d795..00e29c8 100644
> --- a/arch/x86/pci/legacy.c
> +++ b/arch/x86/pci/legacy.c
> @@ -63,5 +63,6 @@ int __init pci_subsys_init(void)
> pci_legacy_init();
> pcibios_irq_init();
> pcibios_init();
> + return 0;
> }
> subsys_initcall(pci_subsys_init);
Looks like Robert already pushed a patch like this via the x86 tree, but at
least it's been fixed.
Thanks,
Jesse
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix pci_subsys_init() to have a return value
2008-07-14 21:21 ` Jesse Barnes
@ 2008-07-14 22:25 ` Robert Richter
0 siblings, 0 replies; 3+ messages in thread
From: Robert Richter @ 2008-07-14 22:25 UTC (permalink / raw)
To: Jesse Barnes; +Cc: David Howells, akpm, linux-pci, linux-kernel
On 14.07.08 14:21:03, Jesse Barnes wrote:
> On Friday, July 11, 2008 2:46 am David Howells wrote:
> > Fix pci_subsys_init() to return a value (0) when it has finished. All the
> > functions it calls currently return 0, so returning 0 here unconditionally
> > rather than gathering the results of its callees would seem reasonable.
> >
> > Signed-off-by: David Howells <dhowells@redhat.com>
> > ---
> >
> > arch/x86/pci/legacy.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >
> > diff --git a/arch/x86/pci/legacy.c b/arch/x86/pci/legacy.c
> > index 3c1d795..00e29c8 100644
> > --- a/arch/x86/pci/legacy.c
> > +++ b/arch/x86/pci/legacy.c
> > @@ -63,5 +63,6 @@ int __init pci_subsys_init(void)
> > pci_legacy_init();
> > pcibios_irq_init();
> > pcibios_init();
> > + return 0;
> > }
> > subsys_initcall(pci_subsys_init);
>
> Looks like Robert already pushed a patch like this via the x86 tree, but at
> least it's been fixed.
Right, there was also another location to fix.
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-14 22:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-11 9:46 [PATCH] Fix pci_subsys_init() to have a return value David Howells
2008-07-14 21:21 ` Jesse Barnes
2008-07-14 22:25 ` Robert Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox