From: Greg KH <greg@kroah.com>
To: David Vrabel <david.vrabel@csr.com>
Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Dropping WUSB/UWB from my patch queue
Date: Tue, 15 Jul 2008 08:53:13 -0700 [thread overview]
Message-ID: <20080715155313.GA3075@kroah.com> (raw)
In-Reply-To: <4871E9F0.60608@csr.com>
On Mon, Jul 07, 2008 at 11:03:28AM +0100, David Vrabel wrote:
> Greg KH wrote:
> > Hi David,
Sorry for the delay, was on vacation all last week without email access,
and am on a business trip this week with very limited email access :(
> > In looking further at the WUSB/UWB code, it doesn't look like it is
> > going to make it for the 2.6.27 kernel tree due to the reliance on some
> > contriversial core USB changes as well as a total lack of documentation
> > for the sysfs apis.
>
> I assume you are referring to the usb_dev_reset_delayed() change here.
> This is only required by the wire adapter code and should not prevent
> the majority of the UWB and WUSB stack from being merged.
Ok, thanks for letting me know, I did not realize this.
> You should postpone:
>
> usb-add-usb_dev_reset_delayed.patch
> wusb-add-the-wire-adapter-core.patch
> wusb-add-hwa-hc-wireless-host-controller-driver.patch
> wusb-wa-abort-rpipe-request-type-fix.patch
Will the code still work properly for users with these patches removed?
If so, I'll reconsider sending this for 2.6.27.
> I will correct the lack of sysfs API documentation this week. Please
> advise on where the documentation should go and its style and format.
> Be aware that some of the API is experimental and subject to change. I
> will ensure the documentation is clear on this and that the Kconfig
> entries depend on EXPERIMENTAL.
>
> Would this be sufficient to reinstate the majority of the UWB and WUSB
> stacks for 2.6.27?
Yes. I'll take what you sent me, and try to reorder things to make it
so that we can get the majority of the code into .27, I don't want this
to live outside the tree for any longer either, that's why I started
working on getting this mess cleaned up in the first place :)
> > Because of this, I've dropped all of the patches from my USB queue, so
> > they will no longer show up in the -next releases anymore.
>
> In future, it would be appreciated if any issues with UWB patches are
> discussed rather than summarily dropping them.
Hey, they were not "dropped" in the format that they suddenly
disappeared, they are still around and useful :)
thanks,
greg k-h
next prev parent reply other threads:[~2008-07-15 16:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 18:00 Dropping WUSB/UWB from my patch queue Greg KH
2008-07-07 10:03 ` David Vrabel
2008-07-15 15:53 ` Greg KH [this message]
2008-07-15 17:48 ` David Vrabel
2008-07-15 18:36 ` Perez-Gonzalez, Inaky
2008-07-16 5:49 ` Greg KH
2008-07-16 9:52 ` David Vrabel
2008-07-16 16:20 ` Perez-Gonzalez, Inaky
2008-07-16 16:23 ` Greg KH
2008-07-16 17:35 ` David Vrabel
2008-07-16 17:55 ` Perez-Gonzalez, Inaky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080715155313.GA3075@kroah.com \
--to=greg@kroah.com \
--cc=david.vrabel@csr.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox