public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] [MIPS] fix missing prototypes in asm/fpu.h
Date: Wed, 16 Jul 2008 09:45:22 +0100	[thread overview]
Message-ID: <20080716084522.GB22957@linux-mips.org> (raw)
In-Reply-To: <1216141052-28005-3-git-send-email-dmitri.vorobiev@movial.fi>

On Tue, Jul 15, 2008 at 07:57:31PM +0300, Dmitri Vorobiev wrote:

> While building the Malta defconfig, sparse spat the following
> warnings:
> 
> >>>>>>>>>>>>>>>>>>
> arch/mips/math-emu/kernel_linkage.c:31:6: warning: symbol
> 'fpu_emulator_init_fpu' was not declared. Should it be static?
> 
> arch/mips/math-emu/kernel_linkage.c:54:5: warning: symbol
> 'fpu_emulator_save_context' was not declared. Should it be
> static?
> 
> arch/mips/math-emu/kernel_linkage.c:68:5: warning: symbol
> 'fpu_emulator_restore_context' was not declared. Should it be
> static?
> >>>>>>>>>>>>>>>>>>
> 
> This patch fixes these errors by adding the proper prototypes
> to the include/asm-mips/fpu.h header, and actually using this
> header in the sparse-spotted source file.

I'm not terribly fond of exporting these private prototypes by making
their prototypes widely available.  I see it's need to make sparse a more
productive tool, so I applied the patch though.

Thanks,

  Ralf

  reply	other threads:[~2008-07-16  8:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-15 16:57 [MIPS] Another small series of cleanups Dmitri Vorobiev
2008-07-15 16:57 ` [PATCH 1/3] [MIPS] make the pcibios_max_latency variable static Dmitri Vorobiev
2008-07-16  8:01   ` [PATCH 1/3 part 2] " Dmitri Vorobiev
2008-07-16  8:43     ` Ralf Baechle
2008-07-16  8:44       ` Dmitri Vorobiev
2008-07-15 16:57 ` [PATCH 2/3] [MIPS] fix missing prototypes in asm/fpu.h Dmitri Vorobiev
2008-07-16  8:45   ` Ralf Baechle [this message]
2008-07-15 16:57 ` [PATCH 3/3] [MIPS] add missing prototypes to asm/page.h Dmitri Vorobiev
2008-07-16  8:46   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080716084522.GB22957@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=dmitri.vorobiev@movial.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox