From: Ingo Molnar <mingo@elte.hu>
To: Matthew Wilcox <matthew@wil.cx>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [build fix] Re: [GIT PATCH] SCSI part 1
Date: Wed, 16 Jul 2008 16:46:02 +0200 [thread overview]
Message-ID: <20080716144602.GB4369@elte.hu> (raw)
In-Reply-To: <20080716144106.GD25255@parisc-linux.org>
* Matthew Wilcox <matthew@wil.cx> wrote:
> On Wed, Jul 16, 2008 at 04:18:05PM +0200, Ingo Molnar wrote:
> > btw., about the technical aspects of the solution, i'm not sure i like
> > these big #ifdef blocks:
>
> It's partly the nature of the beast. There's already several large
> #ifdef blocks in compat_ioctl.c -- CONFIG_NET, CONFIG_VT,
> #CONFIG_SPARC, etc. I think what would help is a bit more grouping so
> #individual blocks get bigger.
yeah, that's OK - but why is scsi.h #ifdef-ed? For example we can
include blkdev.h without #ifdef CONFIG_BLOCK.
Ingo
next prev parent reply other threads:[~2008-07-16 14:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 16:15 [GIT PATCH] SCSI part 1 James Bottomley
2008-07-16 10:16 ` [build fix] " Ingo Molnar
2008-07-16 10:33 ` Ingo Molnar
2008-07-16 13:15 ` Ingo Molnar
2008-07-16 13:28 ` Matthew Wilcox
2008-07-16 13:52 ` James Bottomley
2008-07-16 14:18 ` Ingo Molnar
2008-07-16 14:28 ` James Bottomley
2008-07-16 14:45 ` Ingo Molnar
2008-07-16 15:11 ` James Bottomley
2008-07-16 14:41 ` Matthew Wilcox
2008-07-16 14:46 ` Ingo Molnar [this message]
2008-07-16 14:57 ` Matthew Wilcox
2008-07-16 14:59 ` Ingo Molnar
2008-07-16 14:54 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080716144602.GB4369@elte.hu \
--to=mingo@elte.hu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox