From: Robin Holt <holt@sgi.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: cl@linux-foundation.org, penberg@cs.helsinki.fi,
linux-kernel@vger.kernel.org
Subject: Re: SLUB: simplify re on_each_cpu()
Date: Thu, 17 Jul 2008 06:38:26 -0500 [thread overview]
Message-ID: <20080717113826.GG8534@sgi.com> (raw)
In-Reply-To: <20080716172902.GA5176@martell.zuzino.mipt.ru>
On Wed, Jul 16, 2008 at 09:29:02PM +0400, Alexey Dobriyan wrote:
> on_each_cpu() expands to function call on UP, too.
It looks to me like on_each_cpu is a #define for !SMP. Are you certain
of the need for this change? Are you looking at a different tree than
Linus'?
Thanks,
Robin
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> mm/slub.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1495,15 +1495,7 @@ static void flush_cpu_slab(void *d)
>
> static void flush_all(struct kmem_cache *s)
> {
> -#ifdef CONFIG_SMP
> on_each_cpu(flush_cpu_slab, s, 1);
> -#else
> - unsigned long flags;
> -
> - local_irq_save(flags);
> - flush_cpu_slab(s);
> - local_irq_restore(flags);
> -#endif
> }
>
> /*
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2008-07-17 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 17:29 SLUB: simplify re on_each_cpu() Alexey Dobriyan
2008-07-16 17:36 ` Christoph Lameter
2008-07-16 20:58 ` Pekka Enberg
2008-07-17 11:38 ` Robin Holt [this message]
2008-07-17 12:26 ` Pekka Enberg
2008-07-17 12:39 ` Robin Holt
2008-07-17 12:55 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080717113826.GG8534@sgi.com \
--to=holt@sgi.com \
--cc=adobriyan@gmail.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox