* [PATCH] Fix build on COMPAT platforms when CONFIG_EPOLL is disabled.
@ 2008-07-17 15:31 Atsushi Nemoto
2008-07-17 21:23 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Atsushi Nemoto @ 2008-07-17 15:31 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm
Add missing cond_syscall() entry for compat_sys_epoll_pwait.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
index 5b9b467..0fea0ee 100644
--- a/kernel/sys_ni.c
+++ b/kernel/sys_ni.c
@@ -59,6 +59,7 @@ cond_syscall(sys_epoll_create);
cond_syscall(sys_epoll_ctl);
cond_syscall(sys_epoll_wait);
cond_syscall(sys_epoll_pwait);
+cond_syscall(compat_sys_epoll_pwait);
cond_syscall(sys_semget);
cond_syscall(sys_semop);
cond_syscall(sys_semtimedop);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix build on COMPAT platforms when CONFIG_EPOLL is disabled.
2008-07-17 15:31 [PATCH] Fix build on COMPAT platforms when CONFIG_EPOLL is disabled Atsushi Nemoto
@ 2008-07-17 21:23 ` Andrew Morton
2008-07-17 21:29 ` Alexey Dobriyan
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-07-17 21:23 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-kernel, Davide Libenzi, stable
On Fri, 18 Jul 2008 00:31:08 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> Add missing cond_syscall() entry for compat_sys_epoll_pwait.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
> diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> index 5b9b467..0fea0ee 100644
> --- a/kernel/sys_ni.c
> +++ b/kernel/sys_ni.c
> @@ -59,6 +59,7 @@ cond_syscall(sys_epoll_create);
> cond_syscall(sys_epoll_ctl);
> cond_syscall(sys_epoll_wait);
> cond_syscall(sys_epoll_pwait);
> +cond_syscall(compat_sys_epoll_pwait);
> cond_syscall(sys_semget);
> cond_syscall(sys_semop);
> cond_syscall(sys_semtimedop);
Interesting. It appears that both 2.6.25.x and 2.6.26.x need this
fix as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix build on COMPAT platforms when CONFIG_EPOLL is disabled.
2008-07-17 21:23 ` Andrew Morton
@ 2008-07-17 21:29 ` Alexey Dobriyan
2008-07-17 21:42 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Dobriyan @ 2008-07-17 21:29 UTC (permalink / raw)
To: Andrew Morton; +Cc: Atsushi Nemoto, linux-kernel, Davide Libenzi, stable
On Thu, Jul 17, 2008 at 02:23:14PM -0700, Andrew Morton wrote:
> On Fri, 18 Jul 2008 00:31:08 +0900 (JST)
> Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
>
> > Add missing cond_syscall() entry for compat_sys_epoll_pwait.
> >
> > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> > ---
> > diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> > index 5b9b467..0fea0ee 100644
> > --- a/kernel/sys_ni.c
> > +++ b/kernel/sys_ni.c
> > @@ -59,6 +59,7 @@ cond_syscall(sys_epoll_create);
> > cond_syscall(sys_epoll_ctl);
> > cond_syscall(sys_epoll_wait);
> > cond_syscall(sys_epoll_pwait);
> > +cond_syscall(compat_sys_epoll_pwait);
> > cond_syscall(sys_semget);
> > cond_syscall(sys_semop);
> > cond_syscall(sys_semtimedop);
>
> Interesting. It appears that both 2.6.25.x and 2.6.26.x need this
> fix as well.
IIRC, this happens for other syscalls as well. IIRC, timerfd ones.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix build on COMPAT platforms when CONFIG_EPOLL is disabled.
2008-07-17 21:29 ` Alexey Dobriyan
@ 2008-07-17 21:42 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2008-07-17 21:42 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: anemo, linux-kernel, davidel, stable
On Fri, 18 Jul 2008 01:29:39 +0400
Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Thu, Jul 17, 2008 at 02:23:14PM -0700, Andrew Morton wrote:
> > On Fri, 18 Jul 2008 00:31:08 +0900 (JST)
> > Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> >
> > > Add missing cond_syscall() entry for compat_sys_epoll_pwait.
> > >
> > > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> > > ---
> > > diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> > > index 5b9b467..0fea0ee 100644
> > > --- a/kernel/sys_ni.c
> > > +++ b/kernel/sys_ni.c
> > > @@ -59,6 +59,7 @@ cond_syscall(sys_epoll_create);
> > > cond_syscall(sys_epoll_ctl);
> > > cond_syscall(sys_epoll_wait);
> > > cond_syscall(sys_epoll_pwait);
> > > +cond_syscall(compat_sys_epoll_pwait);
> > > cond_syscall(sys_semget);
> > > cond_syscall(sys_semop);
> > > cond_syscall(sys_semtimedop);
> >
> > Interesting. It appears that both 2.6.25.x and 2.6.26.x need this
> > fix as well.
>
> IIRC, this happens for other syscalls as well. IIRC, timerfd ones.
Well it _did_ do this. But I fixed about four such build errors.
Please check?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-07-17 21:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-17 15:31 [PATCH] Fix build on COMPAT platforms when CONFIG_EPOLL is disabled Atsushi Nemoto
2008-07-17 21:23 ` Andrew Morton
2008-07-17 21:29 ` Alexey Dobriyan
2008-07-17 21:42 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox