Re: [PATCH 1/7] dynamic debug v2 - infrastructure

Dominik Brodowski
2008-07-17T22:56:23Z

Hi,

On Thu, Jul 17, 2008 at 03:32:22PM -0700, Greg KH wrote:
> > that is correct. any callers of dev_dbg() don't have to do anything. its really
> > only the more complex debugging, where there are flags or levels that need to
> > make adjustments to work with the new infrastructure.
>
> For this reason alone, I see no reason why your patch should not be
> merged today. You don't need the other subsystems at this point in time
> in my opinion, it's benifit is huge already.

not to object to this statement, but:

what about the user-visible interface? currently, it's based around one big
debugfs file. What about doing

<debugfs>/dynamic_printk/<module_name>/{enabled[,level][,flag][,modules]}

instead, or even

<sysfs>/module/<module_name>/debug/{enabled[,level][,flag]}

For "shared" modules like cpufreq (only user so far, AFAICS), things might
get a bit more interesting, but we found that out already in the other
thread ;)

Best wishes,
Dominik