Re: [PATCH 1/7] dynamic debug v2 - infrastructure

Greg KH
2008-08-14T14:55:27Z

On Tue, Aug 12, 2008 at 04:46:19PM -0400, Jason Baron wrote:
> On Tue, Aug 12, 2008 at 01:09:08PM -0700, Greg KH wrote:
> > So close, can I have a good changelog comment with the patch so people
> > know what it is when they look in the logs?
> >
> > Care to resend it with that?
> >
>
> Base infrastructure to enable per-module debug messages.

<snip>

Ok, I got the build problem with the usb-gadget drivers all worked out
now, and added this to my driver-core tree.

Very nice stuff, again, thanks for doing this. I'll work to clean up
the USB drivers to all rely on this and not their separate
CONFIG_USB_DEBUG option.

Also, would it make sense to add a patch like the one below to this
code? It might be nice to know when each module's debugging value is
manually changed by the user for the log files.

If you like it, I can merge it in the main patch.

thanks,

greg k-h

---
lib/dynamic_printk.c | 6 ++++++
1 file changed, 6 insertions(+)

--- a/lib/dynamic_printk.c
+++ b/lib/dynamic_printk.c
@@ -288,6 +288,9 @@ static ssize_t pr_debug_write(struct fil
num_enabled++;
dynamic_enabled = DYNAMIC_ENABLED_SOME;
err = 0;
+ printk(KERN_DEBUG
+ "debugging enabled for module %s",
+ elem->name);
} else if (!value && (elem->enable == 1)) {
elem->enable = 0;
num_enabled--;
@@ -304,6 +307,9 @@ static ssize_t pr_debug_write(struct fil
dynamic_enabled =
DYNAMIC_ENABLED_NONE;
err = 0;
+ printk(KERN_DEBUG
+ "debugging disabled for module "
+ "%s", elem->name);
}
}
}