Re: [PATCH 1/7] dynamic debug v2 - infrastructure

Greg KH
2008-08-12T20:12:04Z

On Tue, Aug 12, 2008 at 03:48:17PM -0400, Jason Baron wrote:
> On Mon, Aug 11, 2008 at 03:33:09PM -0700, Greg KH wrote:
> > On Mon, Aug 11, 2008 at 01:36:16PM -0400, Jason Baron wrote:
> > > On Fri, Aug 08, 2008 at 07:38:51PM -0700, Randy Dunlap wrote:
> > > > On Fri, 8 Aug 2008 17:51:53 -0400 Jason Baron wrote:
> > > >
> > > > > Few notes...there is still one control file: <debugfs>/dynamic_printk/modules
> > > > > We can split this up now or later, but I kind of like being able to see all
> > > > > the controls in one file. Also, i've used a djb2 hash function in the code,
> > > > > which i'm not sure is under the correct license/copyright, so i just wanted
> > > > > to point that out as well. see: scripts/basic/hash.c. If its an issue, i can
> > > > > find another hash function.
> > > >
> > > > What license does it have? I don't see one.
> > > >
> > >
> > > hmmm...a search for djb2 finds a number of users, for example, i found this one
> > > which is covered by GPL2, http://www.telegraphics.com.au/svn/dpa/trunk/symtab.c
> > > is that sufficient to say its ok?
> >
> > That's a tough call. I'd run that through the license board of your
> > employer if you have any questions about this, as it is your name with
> > their domain that is going to have the "signed-off-by:" pointing back
> > to.
> >
>
> We're ok with the patch as is...i'm including an updated version below, which
> contains some documentation improvements...as you mentioned before, perhaps
> you can include this patch through the driver tree. It should apply with
> minimal munging, but please point me at a tree, if there are any issues.
>
> thanks,
>
> -Jason
>
>
> Signed-off-by: Jason Baron <jbaron@redhat.com>

So close, can I have a good changelog comment with the patch so people
know what it is when they look in the logs?

Care to resend it with that?

thanks,

greg k-h