Re: [PATCH 1/7] dynamic debug v2 - infrastructure

Greg KH
2008-08-13T03:40:04Z

On Tue, Aug 12, 2008 at 06:16:53PM -0700, Andrew Morton wrote:
> On Tue, 12 Aug 2008 18:08:04 -0700
> Greg KH <greg@kroah.com> wrote:
>
> > On Tue, Aug 12, 2008 at 04:46:19PM -0400, Jason Baron wrote:
> > > On Tue, Aug 12, 2008 at 01:09:08PM -0700, Greg KH wrote:
> > > > So close, can I have a good changelog comment with the patch so people
> > > > know what it is when they look in the logs?
> > > >
> > > > Care to resend it with that?
> > > >
> > >
> > > Base infrastructure to enable per-module debug messages.
> >
> > Ah, so close...
> >
> > With this patch, I get the following build error:
> >
> > CC [M] drivers/usb/gadget/u_ether.o
> > drivers/usb/gadget/u_ether.c: In function ___gether_setup___:
> > drivers/usb/gadget/u_ether.c:787: error: ___KBUILD_MODNAME___ undeclared (first use in this function)
> > drivers/usb/gadget/u_ether.c:787: error: (Each undeclared identifier is reported only once
> > drivers/usb/gadget/u_ether.c:787: error: for each function it appears in.)
> > drivers/usb/gadget/u_ether.c:787: error: unknown field ___Usage___ specified in initializer
> > drivers/usb/gadget/u_ether.c:787: error: expected expression before ___.___ token
> > drivers/usb/gadget/u_ether.c:787: error: initializer element is not constant
> > drivers/usb/gadget/u_ether.c:787: error: (near initialization for ___descriptor.hash___)
> > drivers/usb/gadget/u_ether.c:787: error: ___Usage___ undeclared (first use in this function)
> > drivers/usb/gadget/u_ether.c:787: error: invalid operands to binary << (have ___long long int___ and ___char *___)
> > drivers/usb/gadget/u_ether.c:787: error: expected ___)___ before ___:___ token
> > drivers/usb/gadget/u_ether.c:787: error: invalid operands to binary & (have ___long long int___ and ___char *___)
> > drivers/usb/gadget/u_ether.c:787: error: invalid operands to binary << (have ___long long int___ and ___char *___)
> > drivers/usb/gadget/u_ether.c:787: error: expected ___)___ before ___:___ token
> > drivers/usb/gadget/u_ether.c:787: error: invalid operands to binary & (have ___long long int___ and ___char *___)
> > drivers/usb/gadget/u_ether.c:787: error: expected ___)___ before ___:___ token
> > drivers/usb/gadget/u_ether.c:787: warning: passing argument 4 of _____dynamic_dbg_enabled_helper___ makes integer from pointer without a cast
> > drivers/usb/gadget/u_ether.c:787: error: expected ___)___ before ___KBUILD_MODNAME___
>
> (lol at gcc crap)
>
> > drivers/usb/gadget/u_ether.c:787: warning: too few arguments for format
>
> argh, not that again. We had this with a patch from Jesse a while
> back, which I fixed thusly:

<patch moving KBUILD_MODNAME from a inline function to a macro snipped>

Yeah, I remember that too, but in this case, KBUILD_MODNAME is being
used in a macro, not an inline function, the exact opposite.

Sam, any ideas here? I'll bounce the original patch at you if you
missed it last time.

thanks,

greg k-h