From: Magnus Damm <magnus.damm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
hjk@linutronix.de, gregkh@suse.de, akpm@linux-foundation.org
Subject: [PATCH 02/06] uio: Pass struct uio_mem to mmap functions
Date: Fri, 18 Jul 2008 14:04:18 +0900 [thread overview]
Message-ID: <20080718050418.16250.59161.sendpatchset@rx1.opensource.se> (raw)
In-Reply-To: <20080718050402.16250.25213.sendpatchset@rx1.opensource.se>
From: Magnus Damm <damm@igel.co.jp>
This patch makes the UIO code pass a struct uio_mem pointer to the
mmap functions. This change allows us to remove one uio_find_mem()
call and an error check.
The error check can be removed since the struct uio_mem pointer has
already been verified in uio_mmap().
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
drivers/uio/uio.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
--- 0002/drivers/uio/uio.c
+++ work/drivers/uio/uio.c 2008-07-18 12:40:42.000000000 +0900
@@ -477,17 +477,10 @@ static struct vm_operations_struct uio_v
.fault = uio_vma_fault,
};
-static int uio_mmap_physical(struct vm_area_struct *vma)
+static int uio_mmap_physical(struct vm_area_struct *vma, struct uio_mem *imem)
{
- struct uio_mem *imem = uio_find_mem(vma);
-
- if (!imem)
- return -EINVAL;
-
vma->vm_flags |= VM_IO | VM_RESERVED;
-
vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
-
return remap_pfn_range(vma,
vma->vm_start,
imem->addr >> PAGE_SHIFT,
@@ -495,7 +488,7 @@ static int uio_mmap_physical(struct vm_a
vma->vm_page_prot);
}
-static int uio_mmap_logical(struct vm_area_struct *vma)
+static int uio_mmap_logical(struct vm_area_struct *vma, struct uio_mem *imem)
{
vma->vm_flags |= VM_RESERVED;
vma->vm_ops = &uio_vm_ops;
@@ -532,10 +525,10 @@ static int uio_mmap(struct file *filep,
switch (imem->memtype) {
case UIO_MEM_PHYS:
- return uio_mmap_physical(vma);
+ return uio_mmap_physical(vma, imem);
case UIO_MEM_LOGICAL:
case UIO_MEM_VIRTUAL:
- return uio_mmap_logical(vma);
+ return uio_mmap_logical(vma, imem);
default:
return -EINVAL;
}
next prev parent reply other threads:[~2008-07-18 5:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 5:04 [PATCH 00/06] uio: Various minor changes Magnus Damm
2008-07-18 5:04 ` [PATCH 01/06] uio: Use struct_uio_mem instead of index Magnus Damm
2008-07-18 5:04 ` Magnus Damm [this message]
2008-07-18 5:04 ` [PATCH 03/06] uio: Remove vma->vm_private_data from uio_find_mem() Magnus Damm
2008-07-18 5:04 ` [PATCH 04/06] uio: Store struct uio_mem ptr in vma->vm_private_data Magnus Damm
2008-07-18 5:04 ` [PATCH 05/06] uio: Remove redundant vma->vm_flags setup code Magnus Damm
2008-07-18 5:04 ` [PATCH 06/06] uio: Support multiple UIO_MEM_LOGICAL/VIRTUAL pages Magnus Damm
2008-07-18 15:46 ` [PATCH 00/06] uio: Various minor changes Hans J. Koch
2008-07-25 9:12 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080718050418.16250.59161.sendpatchset@rx1.opensource.se \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox