public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
	hjk@linutronix.de, gregkh@suse.de, akpm@linux-foundation.org
Subject: [PATCH 06/06] uio: Support multiple UIO_MEM_LOGICAL/VIRTUAL pages
Date: Fri, 18 Jul 2008 14:04:51 +0900	[thread overview]
Message-ID: <20080718050451.16250.38058.sendpatchset@rx1.opensource.se> (raw)
In-Reply-To: <20080718050402.16250.25213.sendpatchset@rx1.opensource.se>

From: Magnus Damm <damm@igel.co.jp>

This patch improves the UIO_MEM_LOGICAL and UIO_MEM_VIRTUAL page
fault code to support more than one page of data. Memory allocated
from the slab is however not supported, so a check for that is added
and the documentation gets a little update.

Signed-off-by: Magnus Damm <damm@igel.co.jp>
---

 Documentation/DocBook/uio-howto.tmpl |    2 +-
 drivers/uio/uio.c                    |   10 ++++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

--- 0001/Documentation/DocBook/uio-howto.tmpl
+++ work/Documentation/DocBook/uio-howto.tmpl	2008-07-18 12:45:22.000000000 +0900
@@ -376,7 +376,7 @@ Here's a description of the fields of <v
 <varname>int memtype</varname>: Required if the mapping is used. Set this to
 <varname>UIO_MEM_PHYS</varname> if you you have physical memory on your
 card to be mapped. Use <varname>UIO_MEM_LOGICAL</varname> for logical
-memory (e.g. allocated with <function>kmalloc()</function>). There's also
+memory (e.g. allocated with <function>alloc_pages()</function>). There's also
 <varname>UIO_MEM_VIRTUAL</varname> for virtual memory.
 </para></listitem>
 
--- 0006/drivers/uio/uio.c
+++ work/drivers/uio/uio.c	2008-07-18 12:49:38.000000000 +0900
@@ -455,12 +455,15 @@ static void uio_vma_close(struct vm_area
 static int uio_vma_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
 {
 	struct uio_mem *imem = vma->vm_private_data;
+	unsigned long vaddr = imem->addr;
 	struct page *page;
 
+	vaddr += (vmf->pgoff - vma->vm_pgoff) << PAGE_SHIFT;
+
 	if (imem->memtype == UIO_MEM_LOGICAL)
-		page = virt_to_page(imem->addr);
+		page = virt_to_page(vaddr);
 	else
-		page = vmalloc_to_page((void *)imem->addr);
+		page = vmalloc_to_page((void *)vaddr);
 	get_page(page);
 	vmf->page = page;
 	return 0;
@@ -521,6 +524,9 @@ static int uio_mmap(struct file *filep, 
 		case UIO_MEM_PHYS:
 			return uio_mmap_physical(vma, imem);
 		case UIO_MEM_LOGICAL:
+			if (virt_to_page(imem->addr)->flags & (1 << PG_slab))
+				return -EINVAL; /* kmalloc() not supported */
+			/* fall-through */
 		case UIO_MEM_VIRTUAL:
 			return uio_mmap_logical(vma, imem);
 		default:

  parent reply	other threads:[~2008-07-18  5:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-18  5:04 [PATCH 00/06] uio: Various minor changes Magnus Damm
2008-07-18  5:04 ` [PATCH 01/06] uio: Use struct_uio_mem instead of index Magnus Damm
2008-07-18  5:04 ` [PATCH 02/06] uio: Pass struct uio_mem to mmap functions Magnus Damm
2008-07-18  5:04 ` [PATCH 03/06] uio: Remove vma->vm_private_data from uio_find_mem() Magnus Damm
2008-07-18  5:04 ` [PATCH 04/06] uio: Store struct uio_mem ptr in vma->vm_private_data Magnus Damm
2008-07-18  5:04 ` [PATCH 05/06] uio: Remove redundant vma->vm_flags setup code Magnus Damm
2008-07-18  5:04 ` Magnus Damm [this message]
2008-07-18 15:46 ` [PATCH 00/06] uio: Various minor changes Hans J. Koch
2008-07-25  9:12   ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080718050451.16250.38058.sendpatchset@rx1.opensource.se \
    --to=magnus.damm@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=hjk@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox