Re: [i2c] [PATCH 03/05] resource: add new IORESOURCE_CLK type V2

Ben Dooks
2008-07-18T07:53:21Z

On Fri, Jul 18, 2008 at 04:40:27PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@igel.co.jp>
>
> So far struct resource has been used with the types IORESOURCE_MEM,
> IORESOURCE_IO and IORESOUCE_IRQ to pass I/O and interrupt parameters
> to platform drivers. This patch extends this with IORESOURCE_CLK which
> should be used to pass a clock string to the platform driver. This
> string points out which specific clock that should be used with clk_get()
> for a certain driver instance.
>
> Using a hard coded strings in the device driver won't do since we may
> have multiple instances of drivers that need to use different clocks.

It works already. The S3C24XX has n-number of H and P clocks fed to
each driver, differentiated by the device being supplied. This is
why clk_get() has two arguments, a device pointer and a name.

This might be useful to allow optional clocks to be passed, but I'm
not sure if it is necessary.

> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> ---
>
> Changes since V1:
> - Use a new bit for IORESOURCE_CLK instead of switching to a counter
>
> include/linux/ioport.h | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> --- 0003/include/linux/ioport.h
> +++ work/include/linux/ioport.h 2008-07-18 14:29:48.000000000 +0900
> @@ -34,20 +34,21 @@ struct resource_list {
> */
> #define IORESOURCE_BITS 0x000000ff /* Bus-specific bits */
>
> -#define IORESOURCE_TYPE_BITS 0x00000f00 /* Resource type */
> +#define IORESOURCE_TYPE_BITS 0x00001f00 /* Resource type */
> #define IORESOURCE_IO 0x00000100
> #define IORESOURCE_MEM 0x00000200
> #define IORESOURCE_IRQ 0x00000400
> #define IORESOURCE_DMA 0x00000800
> +#define IORESOURCE_CLK 0x00001000
>
> -#define IORESOURCE_PREFETCH 0x00001000 /* No side effects */
> -#define IORESOURCE_READONLY 0x00002000
> -#define IORESOURCE_CACHEABLE 0x00004000
> -#define IORESOURCE_RANGELENGTH 0x00008000
> -#define IORESOURCE_SHADOWABLE 0x00010000
> +#define IORESOURCE_PREFETCH 0x00002000 /* No side effects */
> +#define IORESOURCE_READONLY 0x00004000
> +#define IORESOURCE_CACHEABLE 0x00008000
> +#define IORESOURCE_RANGELENGTH 0x00010000
> +#define IORESOURCE_SHADOWABLE 0x00020000
>
> -#define IORESOURCE_SIZEALIGN 0x00020000 /* size indicates alignment */
> -#define IORESOURCE_STARTALIGN 0x00040000 /* start field is alignment */
> +#define IORESOURCE_SIZEALIGN 0x00040000 /* size indicates alignment */
> +#define IORESOURCE_STARTALIGN 0x00080000 /* start field is alignment */
>
> #define IORESOURCE_DISABLED 0x10000000
> #define IORESOURCE_UNSET 0x20000000
>
> _______________________________________________
> i2c mailing list
> i2c@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/i2c

--
Ben (ben@fluff.org, http://www.fluff.org/)

'a smiley only costs 4 bytes'