Re: [PATCH 02/23] tracehook: exec

Christoph Hellwig
2008-07-21T08:49:32Z

On Thu, Jul 17, 2008 at 12:28:20AM -0700, Roland McGrath wrote:
> This moves all the ptrace hooks related to exec into tracehook.h inlines.
>
> This also lifts the calls for tracing out of the binfmt load_binary hooks
> into search_binary_handler() after it calls into the binfmt module. This
> change has no effect, since all the binfmt modules' load_binary functions
> did the call at the end on success, and now search_binary_handler() does
> it immediately after return if successful. We consolidate the repeated
> code, and binfmt modules no longer need to import ptrace_notify().

Care to first just consolidate the code from the binary handlers to
exec.c and then restrucure it? Currently mainline doesn't even
have ptrace_event yet so it's hard to verify the code is the same.
It certainly isn't for binfmt_som although that's like just a bugfix
that needs to be documented. Also the two new routines are too large
to be inlined, and I would rather not rely on the guarantee that no
other caller will pop up.