Re: [PATCH 00/23] tracehook

Andrew Morton
2008-07-17T08:52:19Z

On Thu, 17 Jul 2008 00:25:41 -0700 (PDT) Roland McGrath <roland@redhat.com> wrote:

> This patch series introduces the "tracehook" interface layer of inlines
> in <linux/tracehook.h>.

Looks sane to me from a quick scan.

A ~200 byte increase in i386 allnoconfig .text is liveable with. But
nothing defines CONFIG_HAVE_ARCH_TRACEHOOK yet. What effect will that
have?

I don't like the name! We have ftrace and we have static tracepoints
and we have dynamic tracepoints and we have linux trace toolkit and
whatever is in kernel/trace/trace.c etc, etc. Now this work comes
along with _userspace_ tracing capabilities and it goes and calls it,
of all things, "trace"!

Things would be much less confusing were we to do s/trace/xyzzy/g on
the whole patchset.

Apart from that, I think the other big issue with this patchset is that
it doesn't do anything yet. It's effectively a blank cheque. There's
not a lot of point in merging all this work unless we also merge
something which uses it (is this correct?). And afacit the thing which
will use it is utrace and utrace hasn't been sighted for a year or more
and it has met objections.

If we merge this and then utrace crashes on a rocky shore then there
was no (or little) point in having merged this.

Or am I wrong about that? Does it have sufficient standalone value to
justify a standalone merge (yet alone to justify such a late merge)?