public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] replace CONFIG_IOMMU with CONFIG_GART_IOMMU in iommu.h
Date: Fri, 18 Jul 2008 13:31:05 +0200	[thread overview]
Message-ID: <20080718113105.GA13662@8bytes.org> (raw)
In-Reply-To: <20080709162913H.tomof@acm.org>

On Wed, Jul 09, 2008 at 04:29:41PM +0900, FUJITA Tomonori wrote:
> Should be CONFIG_GART_IOMMU instead of CONFIG_IOMMU here?
> 
> Hmm, looks like it would be nice to have more cleanups of iommu.h and
> gart.h.
> 
> This is against tip/master.
> 
> =
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH] replace CONFIG_IOMMU with CONFIG_GART_IOMMU in iommu.h
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
>  include/asm-x86/iommu.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/asm-x86/iommu.h b/include/asm-x86/iommu.h
> index 07862fd..cb7e989 100644
> --- a/include/asm-x86/iommu.h
> +++ b/include/asm-x86/iommu.h
> @@ -5,7 +5,7 @@ extern void pci_iommu_shutdown(void);
>  extern void no_iommu_init(void);
>  extern int force_iommu, no_iommu;
>  extern int iommu_detected;
> -#ifdef CONFIG_IOMMU
> +#ifdef CONFIG_GART_IOMMU
>  extern void gart_iommu_init(void);
>  extern void gart_iommu_shutdown(void);
>  extern void __init gart_parse_options(char *);

The asm-x86/iommu.h file is a leftover from some patches I submitted
last year.  I renamed iommu.h to gart.h but somehow iommu.h still exists
in mainline. I think we should check again if somebody is using that
file and remove it if not.

Joerg

  parent reply	other threads:[~2008-07-18 11:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-09  7:29 [PATCH] replace CONFIG_IOMMU with CONFIG_GART_IOMMU in iommu.h FUJITA Tomonori
2008-07-09  8:52 ` Ingo Molnar
2008-07-09 23:27   ` FUJITA Tomonori
2008-07-10  8:43     ` Ingo Molnar
2008-07-18 11:31 ` Joerg Roedel [this message]
2008-07-19 12:12   ` FUJITA Tomonori
2008-07-19 12:49     ` Joerg Roedel
2008-07-19 13:17       ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080718113105.GA13662@8bytes.org \
    --to=joro@8bytes.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox