public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-kernel@vger.kernel.org, sam@ravnborg.org
Subject: The request_firmware() changes causing problems with make-kpkg
Date: Fri, 18 Jul 2008 07:58:33 -0400	[thread overview]
Message-ID: <20080718115833.GC11221@mit.edu> (raw)

Using 2.6.26-git4 and -git6, and with CONFIG_FIRMWARE_IN_KERNEL=y,
make modules_install is calling firmware_install, which is dropping
files in /lib/firmware --- which make-kpkg is happily picking up and
including in the debian kernel package.  Which was fine --- until I
tried to build and install kernel package for -git6, at which point I
got an error at install time because the second package was tying to
overwrite files installed by the first linux-image file.  Doh!

Given that Ubuntu's firmware loader already tries to find firmware at
/lib/firmware/<kpkg> and only if that fails, to load it from
/lib/firmware, it seems like the obvious thing to do is to add a
quickie CONFIG option which changes the default setting of
INSTALL_FW_PATH in the top-level makefile from /lib/firwmare to
/lib/firmware/<kver>.

Maybe the userspace for other distributions won't support this, but
they can simply not use this CONFIG option for now; but it will solve
the problem for all Ubuntu, and possibly Debian, users who want to
build their own kernel using make-kpkg.  If I cons a patch like this,
is there likely going to be any objections with it getting merged?

Regards,

						- Ted

             reply	other threads:[~2008-07-18 11:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-18 11:58 Theodore Tso [this message]
2008-07-18 12:42 ` The request_firmware() changes causing problems with make-kpkg Marcel Holtmann
2008-07-18 14:14 ` David Woodhouse
2008-07-18 15:21   ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080718115833.GC11221@mit.edu \
    --to=tytso@mit.edu \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox