* kdump: Report actual value of VMCOREINFO_OSRELEASE in VMCOREINFO
@ 2008-07-17 22:07 Bernhard Walle
2008-07-18 14:04 ` Vivek Goyal
0 siblings, 1 reply; 2+ messages in thread
From: Bernhard Walle @ 2008-07-17 22:07 UTC (permalink / raw)
To: Ken'ichi Ohmichi, linux-kernel, kexec, vgoyal
The current implementation reports the structure name as
VMCOREINFO_OSRELEASE in VMCOREINFO, e.g.
VMCOREINFO_OSRELEASE=init_uts_ns.name.release
That doesn't make sense because it's always the same. Instead, use the
value, e.g.
VMCOREINFO_OSRELEASE=2.6.26-rc3
That's also what the 'makedumpfile -g' does.
Signed-off-by: Bernhard Walle <bwalle@suse.de>
diff --git a/include/linux/kexec.h b/include/linux/kexec.h
index 3265968..3c7784d 100644
--- a/include/linux/kexec.h
+++ b/include/linux/kexec.h
@@ -127,8 +127,8 @@ void vmcoreinfo_append_str(const char *fmt, ...)
__attribute__ ((format (printf, 1, 2)));
unsigned long paddr_vmcoreinfo_note(void);
-#define VMCOREINFO_OSRELEASE(name) \
- vmcoreinfo_append_str("OSRELEASE=%s\n", #name)
+#define VMCOREINFO_OSRELEASE(value) \
+ vmcoreinfo_append_str("OSRELEASE=%s\n", value)
#define VMCOREINFO_PAGESIZE(value) \
vmcoreinfo_append_str("PAGESIZE=%ld\n", value)
#define VMCOREINFO_SYMBOL(name) \
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: kdump: Report actual value of VMCOREINFO_OSRELEASE in VMCOREINFO
2008-07-17 22:07 kdump: Report actual value of VMCOREINFO_OSRELEASE in VMCOREINFO Bernhard Walle
@ 2008-07-18 14:04 ` Vivek Goyal
0 siblings, 0 replies; 2+ messages in thread
From: Vivek Goyal @ 2008-07-18 14:04 UTC (permalink / raw)
To: Bernhard Walle; +Cc: Ken'ichi Ohmichi, linux-kernel, kexec
On Fri, Jul 18, 2008 at 12:07:45AM +0200, Bernhard Walle wrote:
> The current implementation reports the structure name as
> VMCOREINFO_OSRELEASE in VMCOREINFO, e.g.
>
> VMCOREINFO_OSRELEASE=init_uts_ns.name.release
>
> That doesn't make sense because it's always the same. Instead, use the
> value, e.g.
>
> VMCOREINFO_OSRELEASE=2.6.26-rc3
>
> That's also what the 'makedumpfile -g' does.
>
> Signed-off-by: Bernhard Walle <bwalle@suse.de>
>
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 3265968..3c7784d 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -127,8 +127,8 @@ void vmcoreinfo_append_str(const char *fmt, ...)
> __attribute__ ((format (printf, 1, 2)));
> unsigned long paddr_vmcoreinfo_note(void);
>
> -#define VMCOREINFO_OSRELEASE(name) \
> - vmcoreinfo_append_str("OSRELEASE=%s\n", #name)
> +#define VMCOREINFO_OSRELEASE(value) \
> + vmcoreinfo_append_str("OSRELEASE=%s\n", value)
> #define VMCOREINFO_PAGESIZE(value) \
> vmcoreinfo_append_str("PAGESIZE=%ld\n", value)
> #define VMCOREINFO_SYMBOL(name) \
Makes sense.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Thanks
Vivek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-18 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-17 22:07 kdump: Report actual value of VMCOREINFO_OSRELEASE in VMCOREINFO Bernhard Walle
2008-07-18 14:04 ` Vivek Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox