Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison overwritten

David Miller
2008-07-21T23:34:00Z

From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Date: Tue, 22 Jul 2008 01:24:48 +0400

> On Mon, Jul 21, 2008 at 09:21:38PM +0200, Ingo Molnar (mingo@elte.hu) wrote:
> > So it's now a strong likelyhood that this crash is a combination of
> > e1000e+netconsole.
>
> e1000_clean_tx_irq() call looks particulary suspicious: it is called
> without adapter->tx_queue_lock in poll controller (netconsole callback)
> and with that lock in NAPI handler.
>
> Can you check kind of this patch:

The call even seems pointless, since the caller will call
->poll() (which is e1000_clean) as the very next action,
and that will invoke e1000_clean_tx_irq() properly.

I would just delete this call from e1000_netpoll() entirely.