Re: [PATCH] x86: warn on apic error

Cyrill Gorcunov
2008-07-18T17:44:24Z

[Vegard Nossum - Fri, Jul 18, 2008 at 07:28:21PM +0200]
| From e89f2a9f33d01a2df7553b63cb1df525c6e75ad4 Mon Sep 17 00:00:00 2001
| From: Vegard Nossum <vegard.nossum@gmail.com>
| Date: Fri, 18 Jul 2008 19:14:06 +0200
| Subject: [PATCH] x86: warn on apic error
|
| There are certain APIC errors which are obviously programmer errors,
| e.g. writing to illegal APIC registers, or sending invalid interrupt
| vectors. Since the error interrupt happens spot on the erroneous code,
| we might as well make a bit of noise about it and display the stack-
| trace.
|
| Cc: Maciej W. Rozycki <macro@linux-mips.org>
| Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
| ---
| arch/x86/kernel/apic_32.c | 1 +
| arch/x86/kernel/apic_64.c | 1 +
| 2 files changed, 2 insertions(+), 0 deletions(-)
|
| diff --git a/arch/x86/kernel/apic_32.c b/arch/x86/kernel/apic_32.c
| index a437d02..b9289cb 100644
| --- a/arch/x86/kernel/apic_32.c
| +++ b/arch/x86/kernel/apic_32.c
| @@ -1317,6 +1317,7 @@ void smp_error_interrupt(struct pt_regs *regs)
| */
| printk(KERN_DEBUG "APIC error on CPU%d: %02lx(%02lx)\n",
| smp_processor_id(), v , v1);
| + WARN_ON(v1 & ((1 << 0) | (1 << 2) | (1 << 5) | (1 << 7)));
| irq_exit();
| }
|
| diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
| index 1e3d32e..2d959f2 100644
| --- a/arch/x86/kernel/apic_64.c
| +++ b/arch/x86/kernel/apic_64.c
| @@ -997,6 +997,7 @@ asmlinkage void smp_error_interrupt(void)
| */
| printk(KERN_DEBUG "APIC error on CPU%d: %02x(%02x)\n",
| smp_processor_id(), v , v1);
| + WARN_ON(v1 & ((1 << 0) | (1 << 2) | (1 << 5) | (1 << 7)));
| irq_exit();
| }
|
| --
| 1.5.5.1
|
|

Hi Vegard, i think you better should use #APIC_ESR_... macroses
from apicdef.h instead of hardcoded bits.

- Cyrill -