Re: [PATCH] x86: warn on apic error

Cyrill Gorcunov
2008-07-18T17:49:43Z

[Vegard Nossum - Fri, Jul 18, 2008 at 07:45:53PM +0200]
| On Fri, Jul 18, 2008 at 7:44 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| > [Vegard Nossum - Fri, Jul 18, 2008 at 07:28:21PM +0200]
| > | From e89f2a9f33d01a2df7553b63cb1df525c6e75ad4 Mon Sep 17 00:00:00 2001
| > | From: Vegard Nossum <vegard.nossum@gmail.com>
| > | Date: Fri, 18 Jul 2008 19:14:06 +0200
| > | Subject: [PATCH] x86: warn on apic error
| > |
| > | There are certain APIC errors which are obviously programmer errors,
| > | e.g. writing to illegal APIC registers, or sending invalid interrupt
| > | vectors. Since the error interrupt happens spot on the erroneous code,
| > | we might as well make a bit of noise about it and display the stack-
| > | trace.
|
| > Hi Vegard, i think you better should use #APIC_ESR_... macroses
| > from apicdef.h instead of hardcoded bits.
|
| OOps. I actually had this in my commit message, but it disappeared mysteriously:
|
| In particular, the errors we do this for are:
|
| - Send CS error
| - Send accept error
| - Send illegal vector
| - Illegal register address
|
| (The error codes are listed in a comment just above the code in
| question.)
|
| But if these definitions exist, then I will use them. Thanks!
|
|
| Vegard
|
| --
| "The animistic metaphor of the bug that maliciously sneaked in while
| the programmer was not looking is intellectually dishonest as it
| disguises that the error is the programmer's own creation."
| -- E. W. Dijkstra, EWD1036
|

iirc, they all were there (though some error codes are specific for
particular processor classes like P4, pentium and other - don't remeber
you could check intel dev manual for this).

- Cyrill -