Re: [PATCH v2] Add GPIO-based MMC/SD driver

Michael Buesch
2008-07-28T13:12:53Z

On Monday 28 July 2008 01:30:07 David Brownell wrote:
> > How to?
>
> Simplest to just rip out the support for using one! And in any case:
> as a rule, any delay should be a function of the target bus speed.

Well, that wasn't exactly an answer to my question. ;)
So setting boardinfo->max_speed_hz to zero will do?

> > Where's that documented?
>
> UTSL ... mmc_spi_probe(), first thing. :)

Well, the code of a function isn't really a documentation for its API. ;)
But well, thanks for the hint.

> Don't export that. It's a (less expressive) subset of the standard
> way to do that.

Well, if we have that code in one place, why would we want to reinvent the
wheel over and over again? We can just export this API and let users use
it instead of requireing them to reinvent it.
I'm really really not too sure where your problem is with exporting
that API. If you don't want to use it, simply don't do so and reinvent
the wheel in your code. I'm prefectly fine with that. But IMO that's not
a good reason to hide the code from everybody else who wants to use it.

> > >
> > > There is no "platform GPIO bus" ...
> >
> > hm??
>
> If you look in /sys/bus you won't see GPIO. It's not a bus.

Oh well... This is getting boring...
Then call it "platform GPIO pins" or "platform GPIO controller" or whatever.
That's really just splitting the hair into 16 parts.

> > People asked me to expose it. It was hidden in the first patch that
> > I submitted. I'm not going to change this just to see the next one
> > yelling "I want to see this interface in public" again.
>
> Could you send me some URLs for that feedback?

It was private. One of the OpenWRT guys requested that to have a
convenient way to define a hardwired MMC card in the platform code
by just defining a simple data structure.

--
Greetings Michael.