From: Joerg Roedel <joro@8bytes.org>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: introduce x86_ops
Date: Sat, 19 Jul 2008 11:36:27 +0200 [thread overview]
Message-ID: <20080719093627.GC31439@8bytes.org> (raw)
In-Reply-To: <86802c440807190219m4cd71274qaea4975a9add15d4@mail.gmail.com>
On Sat, Jul 19, 2008 at 02:19:57AM -0700, Yinghai Lu wrote:
> On Sat, Jul 19, 2008 at 2:16 AM, Joerg Roedel <joro@8bytes.org> wrote:
> > Hi Yinghai,
> >
> > can you please write a short commit message explaining the benefit? Also
> > x86_ops sounds a bit too generic for some architecture specific
> > initialization function pointers imho.
>
> put all over visws_quirks in one structs, and may extend that to othat subarch
Ok, then the struct should have 'quirks' in its name maybe :)
Joerg
next prev parent reply other threads:[~2008-07-19 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 9:07 [PATCH] x86: introduce x86_ops Yinghai Lu
2008-07-19 9:16 ` Joerg Roedel
2008-07-19 9:19 ` Yinghai Lu
2008-07-19 9:36 ` Joerg Roedel [this message]
2008-07-20 1:01 ` [PATCH] x86: use x86_ops with numaq Yinghai Lu
2008-07-20 7:28 ` Ingo Molnar
2008-07-20 1:02 ` [PATCH] x86: add pre_time_init in x86_ops Yinghai Lu
2008-07-20 7:28 ` Ingo Molnar
2008-07-20 7:21 ` [PATCH] x86: introduce x86_ops Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080719093627.GC31439@8bytes.org \
--to=joro@8bytes.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox