Re: [PATCH] x86: introduce x86_ops

Ingo Molnar
2008-07-20T07:21:27Z

* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>
> ---
> arch/x86/kernel/e820.c | 9 +-------
> arch/x86/kernel/mpparse.c | 17 ++++------------
> arch/x86/kernel/setup.c | 4 +++
> arch/x86/kernel/visws_quirks.c | 42 +++++++++++++++++++----------------------
> arch/x86/mach-default/setup.c | 24 +++++++----------------
> include/asm-x86/setup.h | 18 ++++++++++-------
> 6 files changed, 50 insertions(+), 64 deletions(-)

> +extern struct x86_ops *x86_ops;

great cleanup!

one detail: i've renamed x86_ops to x86_quirks (and propagated the
rename into your subseqent patches as well), because this is really
something that is not used by normal hardware.

Ingo