From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: rename PTE_MASK to PTE_PFN_MASK
Date: Tue, 22 Jul 2008 10:36:26 +0200 [thread overview]
Message-ID: <20080722083626.GC2065@elte.hu> (raw)
In-Reply-To: <4885774E.3000909@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Rusty, in his peevish way, complained that macros defining constants
> should have a name which somewhat accurately reflects the actual
> purpose of the constant.
>
> Aside from the fact that PTE_MASK gives no clue as to what's actually
> being masked, and is misleadingly similar to the functionally entirely
> different PMD_MASK, PUD_MASK and PGD_MASK, I don't really see what the
> problem is.
Has Rusty ever heard about the economy of the healthy flow of incoming
regressions? What will we do without obscure names and hard to find
bugs? First he writes a simple and readable hypervisor (ruining a whole
industry based on obscurity!) and now that. It's _so_ unamerican and
unaustralian. I'm worried.
Applied to tip/x86/cleanups anyway. Rusty will find out himself how bad
this whole concept of clean and understandable code is, soon enough!
Ingo
next prev parent reply other threads:[~2008-07-22 8:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 4:31 [PATCH] x86: fix pte_flags() to only return flags, fix lguest Rusty Russell
2008-07-22 4:38 ` Stephen Rothwell
2008-07-22 4:51 ` Jeremy Fitzhardinge
2008-07-22 4:52 ` Rusty Russell
2008-07-22 4:49 ` Jeremy Fitzhardinge
2008-07-22 5:40 ` [PATCH] x86: fix pte_flags() to only return flags, fix lguest (updated) Rusty Russell
2008-07-22 5:59 ` [PATCH 1/2] x86: rename PTE_MASK to PTE_PFN_MASK Jeremy Fitzhardinge
2008-07-22 8:36 ` Ingo Molnar [this message]
2008-07-22 10:58 ` Rusty Russell
2008-07-22 11:55 ` Ingo Molnar
2008-07-22 13:03 ` Johannes Weiner
2008-07-22 14:52 ` Jeremy Fitzhardinge
2008-07-22 15:18 ` Johannes Weiner
2008-07-22 15:23 ` Johannes Weiner
2008-07-22 15:33 ` Ingo Molnar
2008-07-22 15:43 ` Johannes Weiner
2008-07-22 5:59 ` [PATCH 2/2] x86: add PTE_FLAGS_MASK Jeremy Fitzhardinge
2008-07-22 9:04 ` [PATCH] x86: fix pte_flags() to only return flags, fix lguest (updated) Ingo Molnar
2008-07-23 0:59 ` Rusty Russell
2008-07-24 11:31 ` Ingo Molnar
2008-07-25 1:55 ` Rusty Russell
2008-07-28 15:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722083626.GC2065@elte.hu \
--to=mingo@elte.hu \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox