From: Ingo Molnar <mingo@elte.hu>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
Roland McGrath <roland@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Chuck Ebbert <cebbert@redhat.com>
Subject: Re: [patch] Fix crash due to missing debugctlmsr on AMD K6-3
Date: Tue, 22 Jul 2008 14:17:49 +0200 [thread overview]
Message-ID: <20080722121749.GC5806@elte.hu> (raw)
In-Reply-To: <20080722120047.GA6795@host0.dyn.jankratochvil.net>
* Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> Hi,
>
> currently if you use PTRACE_SINGLEBLOCK on AMD K6-3 (i586) it will
> crash. Kernel now wrongly assumes existing DEBUGCTLMSR MSR register
> there.
>
> Removed the assumption also for some other non-K6 CPUs but I am not
> sure there (but it can only bring small inefficiency there if my
> assumption is wrong).
>
> Based on info from Roland McGrath, Chuck Ebbert and Mikulas Patocka.
> More info at:
> https://bugzilla.redhat.com/show_bug.cgi?id=456175
>
> Please Cc me in a reply.
applied to tip/x86/urgent, thanks Jan! The commit below is also for
-stable.
Ingo
----------------->
commit d536b1f86591fb081c7a56eab04e711eb4dab951
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date: Tue Jul 22 14:00:47 2008 +0200
x86: fix crash due to missing debugctlmsr on AMD K6-3
currently if you use PTRACE_SINGLEBLOCK on AMD K6-3 (i586) it will crash.
Kernel now wrongly assumes existing DEBUGCTLMSR MSR register there.
Removed the assumption also for some other non-K6 CPUs but I am not sure there
(but it can only bring small inefficiency there if my assumption is wrong).
Based on info from Roland McGrath, Chuck Ebbert and Mikulas Patocka.
More info at:
https://bugzilla.redhat.com/show_bug.cgi?id=456175
Signed-off-by: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: <stable@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/Kconfig.cpu | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu
index 54b8c02..2c518fb 100644
--- a/arch/x86/Kconfig.cpu
+++ b/arch/x86/Kconfig.cpu
@@ -414,4 +414,4 @@ config X86_MINIMUM_CPU_FAMILY
config X86_DEBUGCTLMSR
def_bool y
- depends on !(M586MMX || M586TSC || M586 || M486 || M386)
+ depends on !(MK6 || MWINCHIPC6 || MWINCHIP2 || MWINCHIP3D || MCYRIXIII || M586MMX || M586TSC || M586 || M486 || M386)
prev parent reply other threads:[~2008-07-22 12:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 12:00 [patch] Fix crash due to missing debugctlmsr on AMD K6-3 Jan Kratochvil
2008-07-22 12:17 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722121749.GC5806@elte.hu \
--to=mingo@elte.hu \
--cc=cebbert@redhat.com \
--cc=jan.kratochvil@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=roland@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox