From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix pte_flags() to only return flags, fix lguest.
Date: Tue, 22 Jul 2008 14:52:41 +1000 [thread overview]
Message-ID: <200807221452.41586.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20080722143800.d392994f.sfr@canb.auug.org.au>
On Tuesday 22 July 2008 14:38:00 Stephen Rothwell wrote:
> Hi Rusty,
>
> On Tue, 22 Jul 2008 14:31:58 +1000 Rusty Russell <rusty@rustcorp.com.au>
wrote:
> > +/* This belongs in pgtable.h, but our includes are too much of a mess.
> > */ +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
> > +#define PTE_FLAGS _AC(0x8000000000000FFF, ULL)
>
> Just a small point: You don't actually need the _AC() because this is
> already in a #ifndef __ASSEMBLY__ section of the file. But better safe
> than sorry, I guess. :-)
Ah, yes, I had them in pgtable.h before I gave up. I'll leave it in: if
someone wants them in asm they can now safely move it.
Thanks,
Rusty.
next prev parent reply other threads:[~2008-07-22 4:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 4:31 [PATCH] x86: fix pte_flags() to only return flags, fix lguest Rusty Russell
2008-07-22 4:38 ` Stephen Rothwell
2008-07-22 4:51 ` Jeremy Fitzhardinge
2008-07-22 4:52 ` Rusty Russell [this message]
2008-07-22 4:49 ` Jeremy Fitzhardinge
2008-07-22 5:40 ` [PATCH] x86: fix pte_flags() to only return flags, fix lguest (updated) Rusty Russell
2008-07-22 5:59 ` [PATCH 1/2] x86: rename PTE_MASK to PTE_PFN_MASK Jeremy Fitzhardinge
2008-07-22 8:36 ` Ingo Molnar
2008-07-22 10:58 ` Rusty Russell
2008-07-22 11:55 ` Ingo Molnar
2008-07-22 13:03 ` Johannes Weiner
2008-07-22 14:52 ` Jeremy Fitzhardinge
2008-07-22 15:18 ` Johannes Weiner
2008-07-22 15:23 ` Johannes Weiner
2008-07-22 15:33 ` Ingo Molnar
2008-07-22 15:43 ` Johannes Weiner
2008-07-22 5:59 ` [PATCH 2/2] x86: add PTE_FLAGS_MASK Jeremy Fitzhardinge
2008-07-22 9:04 ` [PATCH] x86: fix pte_flags() to only return flags, fix lguest (updated) Ingo Molnar
2008-07-23 0:59 ` Rusty Russell
2008-07-24 11:31 ` Ingo Molnar
2008-07-25 1:55 ` Rusty Russell
2008-07-28 15:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807221452.41586.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox