public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org, g.liakhovetski@pengutronix.de,
	Greg KH <greg@kroah.com>
Subject: Re: [patch 2.6.26-rc5] gpio: sysfs interface (updated)
Date: Tue, 22 Jul 2008 16:27:51 -0700	[thread overview]
Message-ID: <20080722162751.e8584d46.akpm@linux-foundation.org> (raw)
In-Reply-To: <200806121153.36557.david-b@pacbell.net>

On Thu, 12 Jun 2008 11:53:36 -0700
David Brownell <david-b@pacbell.net> wrote:

> This adds a simple sysfs interface for GPIOs.

device_create_drvdata() has magically vanished from today's linux-next,
so this code doesn't compile any more.

This:

--- a/drivers/gpio/gpiolib.c~gpio-sysfs-interface-updated-gpio-linux-next-fixes-for-sysfs-support-fix
+++ a/drivers/gpio/gpiolib.c
@@ -453,8 +453,8 @@ int gpio_export(unsigned gpio, bool dire
 	if (status == 0) {
 		struct device	*dev;
 
-		dev = device_create_drvdata(&gpio_class, desc->chip->dev, 0,
-				desc, "gpio%d", gpio);
+		dev = device_create(&gpio_class, desc->chip->dev, 0, desc,
+					"gpio%d", gpio);
 		if (dev) {
 			if (direction_may_change)
 				status = sysfs_create_group(&dev->kobj,
@@ -537,8 +537,8 @@ static int gpiochip_export(struct gpio_c
 
 	/* use chip->base for the ID; it's already known to be unique */
 	mutex_lock(&sysfs_lock);
-	dev = device_create_drvdata(&gpio_class, chip->dev, 0, chip,
-			"gpiochip%d", chip->base);
+	dev = device_create(&gpio_class, chip->dev, 0, chip, "gpiochip%d",
+				chip->base);
 	if (dev) {
 		status = sysfs_create_group(&dev->kobj,
 				&gpiochip_attr_group);
_

seems to compile.

  reply	other threads:[~2008-07-22 23:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 18:53 [patch 2.6.26-rc5] gpio: sysfs interface (updated) David Brownell
2008-07-22 23:27 ` Andrew Morton [this message]
2008-07-22 23:28   ` Greg KH
2008-07-22 23:39     ` Andrew Morton
2008-07-22 23:51       ` Greg KH
2008-07-22 23:50     ` Andrew Morton
2008-07-23  0:02       ` Greg KH
2008-07-23  0:01     ` David Brownell
2008-07-23  0:11       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080722162751.e8584d46.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david-b@pacbell.net \
    --cc=g.liakhovetski@pengutronix.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox