The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jarod Wilson <jwilson@redhat.com>
To: linux1394-devel@lists.sourceforge.net
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: fw-ohci: TSB43AB22/A dualbuffer workaround
Date: Tue, 22 Jul 2008 18:11:26 -0400	[thread overview]
Message-ID: <200807221811.26653.jwilson@redhat.com> (raw)
In-Reply-To: <tkrat.6a555e76ba524e73@s5r6.in-berlin.de>

On Tuesday 22 July 2008 12:41:10 pm Stefan Richter wrote:
> Isochronous reception in dualbuffer is reportedly broken with
> TI TSB43AB22A on x86-64.  Descriptor addresses above 2G have been
> determined as the trigger:
> https://bugzilla.redhat.com/show_bug.cgi?id=435550
>
> Two fixes are possible:
>   - pci_set_consistent_dma_mask(pdev, DMA_31BIT_MASK);
>     at least when IR descriptors are allocated, or
>   - simply don't use dualbuffer.
> This fix implements the latter workaround.
>
> But we keep using dualbuffer on x86-32 which won't give us highmen (and
> thus physical addresses outside the 31bit range) in coherent DMA memory
> allocations.  Right now we could for example also whitelist PPC32, but
> DMA mapping implementation details are expected to change there.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Still hoping we can get some confirmation of a chipset bug or a fix from TI 
for this controller, but in the interim, this seems to be the most reasonable 
route to go right now.

Signed-off-by: Jarod Wilson <jwilson@redhat.com>

-- 
Jarod Wilson
jwilson@redhat.com

  reply	other threads:[~2008-07-22 22:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22 16:41 [PATCH] firewire: fw-ohci: TSB43AB22/A dualbuffer workaround Stefan Richter
2008-07-22 22:11 ` Jarod Wilson [this message]
2008-07-22 23:05   ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807221811.26653.jwilson@redhat.com \
    --to=jwilson@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox