From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753955AbYGVUsi (ORCPT ); Tue, 22 Jul 2008 16:48:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751729AbYGVUsa (ORCPT ); Tue, 22 Jul 2008 16:48:30 -0400 Received: from rtsoft3.corbina.net ([85.21.88.6]:8050 "EHLO buildserver.ru.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751557AbYGVUs3 (ORCPT ); Tue, 22 Jul 2008 16:48:29 -0400 Date: Wed, 23 Jul 2008 00:48:27 +0400 From: Anton Vorontsov To: David Brownell Cc: Kumar Gala , linuxppc-dev list , Linux Kernel list , Alan Cox , Benjamin Herrenschmidt Subject: Re: latest tree build failure -- cpm uart & gpio Message-ID: <20080722204827.GA16227@polina.dev.rtsoft.ru> Reply-To: avorontsov@ru.mvista.com References: <20080722145330.GA2315@polina.dev.rtsoft.ru> <200807221233.16723.david-b@pacbell.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Disposition: inline In-Reply-To: <200807221233.16723.david-b@pacbell.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 22, 2008 at 12:33:16PM -0700, David Brownell wrote: > On Tuesday 22 July 2008, Anton Vorontsov wrote: > > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote: > > > can someone look at the following compile failure in linus's tree. I'm > > > guessing part of this has to do with Alan's tty changes (and might > > > already be addressed?). > > > > > > include/asm-generic/gpio.h:131: error: implicit declaration of function > > > 'gpio_get_value' > > > include/asm-generic/gpio.h:137: error: implicit declaration of function > > > 'gpio_set_value' > > > > I think this patch should help: > > > > [OF] of_gpio: should use new header > > http://patchwork.ozlabs.org/linuxppc/patch?id=18750 > > Is that confirmed as fixing this, vs just being the Right Thing To Do? Just applied the patch locally and the issue is not reproducible anymore. > > David, can you please Ack it? See Benjamin's mail: > > http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html > > If you like ... but this is an OF-specific change, making > it conform with the interface spec, so I wouldn't expect > this to need more approvals than it's already got. > > Acked-by: David Brownell Thanks. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2