public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 03/10] ide: remove superfluous check from ide_disk_special()
Date: Tue, 22 Jul 2008 23:12:20 +0200	[thread overview]
Message-ID: <20080722211220.20478.34892.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20080722211159.20478.74184.sendpatchset@localhost.localdomain>

This condition is checked by both ide_disk_init_mult_count()
and set_multcount() so no need to do it again in ide_disk_special().

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-io.c |    2 --
 1 file changed, 2 deletions(-)

Index: b/drivers/ide/ide-io.c
===================================================================
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -540,8 +540,6 @@ static ide_startstop_t ide_disk_special(
 		ide_tf_set_restore_cmd(drive, &args.tf);
 	} else if (s->b.set_multmode) {
 		s->b.set_multmode = 0;
-		if (drive->mult_req > drive->id->max_multsect)
-			drive->mult_req = drive->id->max_multsect;
 		ide_tf_set_setmult_cmd(drive, &args.tf);
 	} else if (s->all) {
 		int special = s->all;

  parent reply	other threads:[~2008-07-22 21:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22 21:11 [PATCH 00/10] ide: make ide 'struct hd_driveid'-free Bartlomiej Zolnierkiewicz
2008-07-22 21:12 ` [PATCH 01/10] ide: fix pre-EIDE SWDMA support on big-endian Bartlomiej Zolnierkiewicz
2008-07-22 21:12 ` [PATCH 02/10] ide: fix ide_fix_driveid() Bartlomiej Zolnierkiewicz
2008-07-22 21:12 ` Bartlomiej Zolnierkiewicz [this message]
2008-07-22 21:12 ` [PATCH 04/10] ide: cleanup ide_disk_init_mult_count() Bartlomiej Zolnierkiewicz
2008-07-22 21:12 ` [PATCH 05/10] ide: cleanup ide_fix_driveid() Bartlomiej Zolnierkiewicz
2008-07-22 21:12 ` [PATCH 06/10] ide: make drive->id an union Bartlomiej Zolnierkiewicz
2008-07-22 21:12 ` [PATCH 07/10] ide: remove drive->driveid Bartlomiej Zolnierkiewicz
2008-07-22 21:12 ` [PATCH 08/10] ide: use ata_id_current_chs_valid() Bartlomiej Zolnierkiewicz
2008-07-22 21:13 ` [PATCH 09/10] ide-disk: use ata_id_wcache_enabled() Bartlomiej Zolnierkiewicz
2008-07-22 21:13 ` [PATCH 10/10] ide-disk: use ata_id_hpa_enabled() Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080722211220.20478.34892.sendpatchset@localhost.localdomain \
    --to=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox